-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(@aws-amplify/analytics): Remove lodash from types #6819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "exclude": [ | ||
| "src/setupTests.ts" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that our .prettierrc correctly formatted .json to be consistent with JSON.stringify(obj, null, 2) (which is what NPM & yarn use), but I didn't want to bother with that here.
Codecov Report
@@ Coverage Diff @@
## main #6819 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 212 212
Lines 13145 13145
Branches 2566 2470 -96
=======================================
Hits 9642 9642
- Misses 3309 3339 +30
+ Partials 194 164 -30
Continue to review full report at Codecov.
|
iartemiev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
…6819) Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: Resolves #5735
#6131 fixes #5735, but this PR removes a previous
lodashwith tslint:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.