Skip to content

Conversation

@ericclemmons
Copy link
Contributor

Issue #, if available: Resolves #5735

#6131 fixes #5735, but this PR removes a previous lodash with tslint:

#5735 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

"exclude": [
"src/setupTests.ts"
]
} No newline at end of file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that our .prettierrc correctly formatted .json to be consistent with JSON.stringify(obj, null, 2) (which is what NPM & yarn use), but I didn't want to bother with that here.

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #6819 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6819   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files         212      212           
  Lines       13145    13145           
  Branches     2566     2470   -96     
=======================================
  Hits         9642     9642           
- Misses       3309     3339   +30     
+ Partials      194      164   -30     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 31.51% <0.00%> (ø)
packages/analytics/src/Analytics.ts 63.58% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.41% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.48% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.69% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e089a...bc77037. Read the comment docs.

Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ericclemmons ericclemmons merged commit be36f82 into aws-amplify:main Sep 17, 2020
@ericclemmons ericclemmons deleted the 5735-lodash branch September 17, 2020 19:58
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
…6819)

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
iartemiev added a commit that referenced this pull request Oct 13, 2020
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with dependencies in analytics package.

2 participants