@feat(@aws-amplify/ui-components): Error/audio handling and css improvements#6672
Merged
wlee221 merged 7 commits intoui-components/mainfrom Aug 28, 2020
Merged
Conversation
wlee221
changed the title
wlee221
changed the title
|
This pull request introduces 1 alert and fixes 1 when merging f66a008 into abf8e82 - view on LGTM.com new alerts:
fixed alerts:
|
ashika01
reviewed
Aug 28, 2020
| this.playbackSource.start(0); | ||
| }; | ||
| const errorCallback = err => { | ||
| console.error('test'); |
Contributor
There was a problem hiding this comment.
I think this needs to be removed?
Contributor
Author
There was a problem hiding this comment.
oh no i did it again
Contributor
There was a problem hiding this comment.
Happens to all. No worries
ashika01
approved these changes
Aug 28, 2020
Contributor
ashika01
left a comment
ashika01
left a comment
There was a problem hiding this comment.
Looks great 🚀 There is one line that needs to be removed and this can be merged 👍
Contributor
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This PR makes improvements to chatbot that is on
ui-previewright now.Improvements:
Fix:
enterkeystroke when only voice is enabled.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.