Skip to content

Conversation

@iartemiev
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested a review from elorzafe August 24, 2020 21:55
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iartemiev !! 🥇

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #6638 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6638   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files         208      208           
  Lines       12928    12928           
  Branches     2526     2433   -93     
=======================================
  Hits         9477     9477           
- Misses       3260     3288   +28     
+ Partials      191      163   -28     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 31.67% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.38% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.48% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.69% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d5e17...9781620. Read the comment docs.

@iartemiev iartemiev merged commit 46770e9 into main Aug 24, 2020
@iartemiev iartemiev deleted the fix-aws-amplify-angular-build branch August 24, 2020 22:14
@wlee221
Copy link
Contributor

wlee221 commented Aug 24, 2020

Thanks @iartemiev!!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants