Skip to content

Conversation

@amhinson
Copy link
Contributor

@amhinson amhinson commented Aug 21, 2020

Issue #, if available:
#6616

Description of changes:
This will fetch new guest credentials if the existing ones become disabled or invalid, similar to what the library was doing before the V3 modularization update.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #6618 into main will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6618      +/-   ##
==========================================
- Coverage   73.30%   73.23%   -0.08%     
==========================================
  Files         208      208              
  Lines       12928    12941      +13     
  Branches     2433     2436       +3     
==========================================
  Hits         9477     9477              
- Misses       3288     3301      +13     
  Partials      163      163              
Impacted Files Coverage Δ
packages/core/src/Credentials.ts 29.91% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d3182...c25b838. Read the comment docs.

@amhinson amhinson self-assigned this Aug 24, 2020
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @amhinson Thank you! 👍

@amhinson amhinson merged commit 7b904bf into aws-amplify:main Aug 24, 2020
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
…t found (aws-amplify#6618)

* retry guest credentials if identity id isn't found
iartemiev pushed a commit that referenced this pull request Oct 13, 2020
…t found (#6618)

* retry guest credentials if identity id isn't found
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants