Skip to content

Force clear credentials when bypassCache: true#6581

Merged
elorzafe merged 1 commit intoaws-amplify:mainfrom
elorzafe:fix/auth-bypasscache-refresh
Aug 17, 2020
Merged

Force clear credentials when bypassCache: true#6581
elorzafe merged 1 commit intoaws-amplify:mainfrom
elorzafe:fix/auth-bypasscache-refresh

Conversation

@elorzafe
Copy link
Contributor

Issue #, if available:
Fixes: #3938
Description of changes:
Clearing credentials when bypassCache: true for Auth.currentAuthenticatedUser, that will lazy allow to lazy load AWS Credentials with using the refreshed token.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #6581 into main will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6581      +/-   ##
==========================================
+ Coverage   73.26%   73.31%   +0.05%     
==========================================
  Files         208      208              
  Lines       12920    12922       +2     
  Branches     2432     2433       +1     
==========================================
+ Hits         9466     9474       +8     
+ Misses       3291     3285       -6     
  Partials      163      163              
Impacted Files Coverage Δ
packages/auth/src/Auth.ts 86.40% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50933b...5483196. Read the comment docs.

@elorzafe elorzafe force-pushed the fix/auth-bypasscache-refresh branch from 3f1645b to 5483196 Compare August 14, 2020 23:26
Copy link
Contributor

@harrysolovay harrysolovay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

@elorzafe elorzafe merged commit 128527c into aws-amplify:main Aug 17, 2020
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force refresh of credentials with updated role assignments

4 participants