-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(CVE-2020-14001): Update kramdown to 2.3.0 #6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # This will help ensure the proper Jekyll version is running. | ||
| # Happy Jekylling! | ||
| gem "jekyll", "~> 3.6.2" | ||
| gem "jekyll" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Gemfile.lock reflects the version without explicitly setting it here.
This avoids transient problems with bundle update jekyll which won't do squat due to this pinning.
| kramdown (= 2.3.0) | ||
| kramdown-parser-gfm (= 1.1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundle update kramdown isn't sufficient due to jekyll's requirement of kramdown@1.
Codecov Report
@@ Coverage Diff @@
## main #6564 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 208 208
Lines 12920 12920
Branches 2525 2525
=======================================
Hits 9466 9466
Misses 3263 3263
Partials 191 191 Continue to review full report at Codecov.
|
sammartinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
* Got how to update from aws-amplify/amplify-js#6564
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
Updated
jekyll+github-pagesto latest, since they were using kramdown v1.Validated by running
bundle exec jekyll serveto check out site &yarn docsfor generating the/apipages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.