(small fix) upgrade DataStore missing config log from info to warn #6562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade DataStore missing config log from info to warn to avoid user error
swyxio
changed the title
manueliglesias
approved these changes
Aug 12, 2020
Contributor
manueliglesias
left a comment
manueliglesias
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks @sw-yx !
Codecov Report
@@ Coverage Diff @@
## main #6562 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 208 208
Lines 12920 12920
Branches 2525 2432 -93
=======================================
Hits 9466 9466
- Misses 3263 3291 +28
+ Partials 191 163 -28
Continue to review full report at Codecov.
|
nubpro
pushed a commit
to nubpro/amplify-js
that referenced
this pull request
Oct 2, 2020
) upgrade DataStore missing config log from info to warn to avoid user error Co-authored-by: Sam Martinez <[email protected]>
iartemiev
pushed a commit
that referenced
this pull request
Oct 13, 2020
upgrade DataStore missing config log from info to warn to avoid user error Co-authored-by: Sam Martinez <[email protected]>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade DataStore missing config log from info to warn to avoid user error
Issue #, if available: n/a
Description of changes:
when users forget to
Amplify.configure, DataStore still works, but this warning message is hidden bc it is at the info level which is hidden by default. This fixes the message towarninstead ofinfo.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.