Skip to content

Conversation

@ericclemmons
Copy link
Contributor

Issue #, if available:

Fixes #5029 & adds to #5112 to replace any with CodeDeliveryDetails


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

): void;
public resendConfirmationCode(
callback: NodeCallback<Error, 'SUCCESS'>,
callback: NodeCallback<Error, any>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be more specific with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not without inspecting the payload:
https://github.com/aws-amplify/amplify-js/pull/5112/files#r396791471

Also, this PR can't successfully be updated to the latest branch via GitHub's GUI for some reason. We may be better off closing this in favor of: #5112.

(I was attempting to pull in the author's latest code, but unsuccessfully)

@amhinson
Copy link
Contributor

Closing in favor of #5112

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent CodeDeliveryDetails usage.

3 participants