Skip to content

Conversation

@mahayash315
Copy link
Contributor

Issue #, if available:
#6556

Description of changes:
This change fixes the inconsistency of AuthStrategy definition between Amplify JS Datastore and Amplify CLI GraphQL Transformer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mahayash315 mahayash315 changed the title fix AuthStrategy group to groups fix(@aws-amplify/datastore): AuthStrategy group to groups Aug 12, 2020
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #6557 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6557   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files         208      208           
  Lines       12942    12942           
  Branches     2530     2437   -93     
=======================================
  Hits         9478     9478           
- Misses       3272     3301   +29     
+ Partials      192      163   -29     
Impacted Files Coverage Δ
packages/datastore/src/types.ts 83.92% <ø> (ø)
...ages/datastore/src/sync/processors/subscription.ts 42.58% <100.00%> (ø)
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 29.91% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.38% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.48% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84af018...3649e99. Read the comment docs.

@amhinson amhinson requested a review from iartemiev August 19, 2020 21:40
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @mahayash315

@iartemiev iartemiev merged commit 50d0ff4 into aws-amplify:main Aug 26, 2020
@mahayash315 mahayash315 deleted the datastore/bug-inconsistent-authstrategy branch August 27, 2020 07:52
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
iartemiev pushed a commit that referenced this pull request Oct 13, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants