Skip to content

Analytics retry issue #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
powerful23 merged 5 commits into from
Apr 12, 2018
Merged

Analytics retry issue #644

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
05417c4
src
powerful23 Apr 10, 2018
dfb2d5b
Merge remote-tracking branch 'upstream/master'
powerful23 Apr 12, 2018
5fe9f4f
mionr change
powerful23 Apr 12, 2018
5096370
minor change
powerful23 Apr 12, 2018
ff402ee
adding log
powerful23 Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/aws-amplify/src/Analytics/Analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const logger = new Logger('AnalyticsClass');
const BUFFER_SIZE = 1000;
const MAX_SIZE_PER_FLUSH = BUFFER_SIZE * 0.1;
const interval = 5*1000; // 5s
const RESEND_LIMIT = 5;
/**
* Provide mobile analytics client functions
*/
Expand Down Expand Up @@ -132,7 +133,7 @@ export default class AnalyticsClass {
if (!ensureCredentails) return Promise.resolve(false);

const timestamp = new Date().getTime();
const params = {eventName: '_session_start', timestamp, config: this._config};
const params = { eventName: '_session_start', timestamp, config: this._config };
return this._putToBuffer(params);
}

Expand All @@ -151,7 +152,7 @@ export default class AnalyticsClass {
if (!ensureCredentails) return Promise.resolve(false);

const timestamp = new Date().getTime();
const params = {eventName: '_session_stop', timestamp, config: this._config};
const params = { eventName: '_session_stop', timestamp, config: this._config };
return this._putToBuffer(params);
}

Expand All @@ -167,7 +168,7 @@ export default class AnalyticsClass {
if (!ensureCredentails) return Promise.resolve(false);

const timestamp = new Date().getTime();
const params = {eventName, attributes, metrics, timestamp, config: this._config};
const params = { eventName, attributes, metrics, timestamp, config: this._config };
return this._putToBuffer(params);
}

Expand All @@ -192,7 +193,16 @@ export default class AnalyticsClass {
pluggable.record(params)
.then(success => {
if (!success) {
that._putToBuffer(params);
params.resendLimits = typeof params.resendLimits === 'number' ?
params.resendLimits : RESEND_LIMIT;
if (params.resendLimits > 0) {
logger.debug(
`resending event ${params.eventName} with ${params.resendLimits} retry times left`);
params.resendLimits -= 1;
that._putToBuffer(params);
} else {
logger.debug(`retry times used up for event ${params.eventName}`);
}
}
});
});
Expand Down