Skip to content

Adds lodash as an explicit dependency. #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amhinson merged 4 commits into from
Aug 20, 2020
Merged

Adds lodash as an explicit dependency. #6131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ad6e04
Adds lodash as an explicit dependency.
quisido Jun 21, 2020
ee04765
Merge branch 'main' into patch-1
amhinson Aug 20, 2020
f96bae7
Merge branch 'main' into patch-1
iartemiev Aug 20, 2020
55a382a
update lodash imports
amhinson Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"@aws-sdk/client-personalize-events": "1.0.0-gamma.4",
"@aws-sdk/client-pinpoint": "1.0.0-gamma.4",
"@aws-sdk/util-utf8-browser": "1.0.0-gamma.3",
"lodash": "^4.17.20",
"uuid": "^3.2.1"
},
"jest": {
Expand Down
7 changes: 4 additions & 3 deletions packages/analytics/src/Providers/AmazonPersonalizeHelper/SessionInfoManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@
* CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions
* and limitations under the License.
*/
import { RequestParams, SessionInfo } from './DataType';
import { isEmpty, isEqual } from 'lodash';
import { SessionInfo } from './DataType';
import isEmpty from 'lodash/isEmpty';
import isEqual from 'lodash/isEqual';
import { v1 as uuid } from 'uuid';
import { StorageHelper, ConsoleLogger as Logger, JS } from '@aws-amplify/core';
Copy link
Contributor

@sammartinez sammartinez Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the StorageHelper here?

Copy link
Contributor

@amhinson amhinson Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't being used (along with RequestParams) so I just removed them.

import { ConsoleLogger as Logger, JS } from '@aws-amplify/core';

import Cache from '@aws-amplify/cache';

Expand Down
4 changes: 3 additions & 1 deletion packages/analytics/src/Providers/AmazonPersonalizeProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ import {
SessionInfoManager,
MediaAutoTrack,
} from './AmazonPersonalizeHelper';
import { isEmpty, isEqual, get } from 'lodash';
import get from 'lodash/get';
import isEmpty from 'lodash/isEmpty';
import isEqual from 'lodash/isEqual';
import { AnalyticsProvider } from '../types';

const logger = new Logger('AmazonPersonalizeProvider');
Expand Down
3 changes: 2 additions & 1 deletion packages/analytics/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"../../node_modules/@types"
],
// temporary fix
"types": ["node", "lodash"]
"types": ["node", "lodash"],
"esModuleInterop": true
},
"include": [
"src/**/*"
Expand Down