Skip to content

Conversation

@neilime
Copy link
Contributor

@neilime neilime commented Jun 3, 2020

Issue #, if available:

import { GraphQLResult } from '@aws-amplify/api-graphql';

const result = { errors: [{ message: 'test' }] } as GraphQLResult;

if (result.errors) {
  console.log(result.errors[0].message); 
  // Typescript error `Property 'message' does not exist on type 'object'`
}

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #5994 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5994   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files         208      208           
  Lines       12922    12922           
  Branches     2433     2433           
=======================================
  Hits         9474     9474           
  Misses       3285     3285           
  Partials      163      163           
Impacted Files Coverage Δ
packages/api-graphql/src/types/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9164b37...992b5c2. Read the comment docs.

@amhinson amhinson changed the base branch from master to main June 18, 2020 18:48
@neilime neilime requested a review from amhinson August 18, 2020 19:11
Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neilime! 🙏

@amhinson amhinson merged commit 2b4f6d8 into aws-amplify:main Aug 19, 2020
@neilime neilime deleted the patch-1 branch August 20, 2020 10:43
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
iartemiev pushed a commit that referenced this pull request Oct 13, 2020
Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants