-
Notifications
You must be signed in to change notification settings - Fork 2.2k
add Japanese translations #4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4196 +/- ##
==========================================
- Coverage 73.48% 73.29% -0.19%
==========================================
Files 205 208 +3
Lines 12621 12925 +304
Branches 2460 2526 +66
==========================================
+ Hits 9275 9474 +199
- Misses 3157 3260 +103
- Partials 189 191 +2
Continue to review full report at Codecov.
|
| 'Invalid password format': '密码格式错误', | ||
| 'Invalid phone number format': '电话格式错误,请使用格式 +12345678900', | ||
| }, | ||
| ja: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koty There seems to be dead spaces in a lot of these strings, can you please clean them up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Sign In': 'サインイン ',
should be
'Sign In': 'サインイン',
sammartinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮 Thanks for Contributing!
This reverts commit 9056785.
Co-authored-by: Sam Martinez <samlmar@amazon.com>
Co-authored-by: Sam Martinez <samlmar@amazon.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
I've added a bunch of Japanese translation for React Auth.
Sign in
Reset password
Create account
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.