Skip to content

Conversation

@koty
Copy link
Contributor

@koty koty commented Oct 17, 2019

Description of changes:
I've added a bunch of Japanese translation for React Auth.

Sign in

image

Reset password

image

Create account

image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #4196 into main will decrease coverage by 0.18%.
The diff coverage is 84.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4196      +/-   ##
==========================================
- Coverage   73.48%   73.29%   -0.19%     
==========================================
  Files         205      208       +3     
  Lines       12621    12925     +304     
  Branches     2460     2526      +66     
==========================================
+ Hits         9275     9474     +199     
- Misses       3157     3260     +103     
- Partials      189      191       +2     
Impacted Files Coverage Δ
packages/api-graphql/src/types/index.ts 100.00% <ø> (ø)
packages/api/src/API.ts 95.12% <ø> (ø)
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (+6.47%) ⬆️
packages/datastore/src/sync/index.ts 15.38% <0.00%> (-0.06%) ⬇️
packages/datastore/src/sync/processors/mutation.ts 13.19% <0.00%> (ø)
...ages/datastore/src/sync/processors/subscription.ts 42.58% <0.00%> (-0.28%) ⬇️
...pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts 18.37% <0.00%> (-0.17%) ⬇️
...ges/analytics/src/Providers/AWSPinpointProvider.ts 74.69% <20.00%> (-0.84%) ⬇️
...kages/aws-amplify-react/src/Auth/Authenticator.tsx 71.85% <20.00%> (-3.74%) ⬇️
packages/storage/src/providers/AWSS3Provider.ts 86.97% <66.66%> (-0.33%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d91562...e185e0a. Read the comment docs.

'Invalid password format': '密码格式错误',
'Invalid phone number format': '电话格式错误,请使用格式 +12345678900',
},
ja: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koty There seems to be dead spaces in a lot of these strings, can you please clean them up?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Sign In': 'サインイン ',

should be

'Sign In': 'サインイン',

@amhinson amhinson changed the base branch from master to main June 18, 2020 19:02
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮 Thanks for Contributing!

@sammartinez sammartinez merged commit 9056785 into aws-amplify:main Aug 20, 2020
sammartinez added a commit that referenced this pull request Aug 20, 2020
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
Co-authored-by: Sam Martinez <samlmar@amazon.com>
iartemiev pushed a commit that referenced this pull request Oct 13, 2020
Co-authored-by: Sam Martinez <samlmar@amazon.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants