Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): request initiateAuth with retry #13854

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 26, 2024

Description of changes

  • Now use requestWithRetry to handle the InitiateAuth request used by refreshSession on Network error
  • Enhanced the unit tests to cover the scenario using the library with Node.js 18+

Issue #, if available

#13830

Description of how you validated changes

  • Unit tests
  • Manual tests with a React Native sample running on Android emulator. Verified that the underlying network request was being retried when the device disconnected

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner September 26, 2024 18:51
@HuiSF HuiSF merged commit 33640c4 into v5-stable Oct 8, 2024
28 checks passed
@HuiSF HuiSF deleted the hui/v5/fix/auth/retry-initiate-auth branch October 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants