Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): Add granular user agent for Ai #13835

Merged
merged 19 commits into from
Oct 1, 2024
Merged

(feat): Add granular user agent for Ai #13835

merged 19 commits into from
Oct 1, 2024

Conversation

yuhengshs
Copy link
Contributor

@yuhengshs yuhengshs commented Sep 20, 2024 •
edited
Loading

Description of changes

  • Added AI related enums and Actions in Platform/types
  • Added override symbol in GraphQLAPI.ts to override user agents. Added symbol in the constant file.

Issue #, if available

Description of how you validated changes

  • Tested valid in Sample Apps. Console log is outputting the corresponding user-agents.

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cshfang
cshfang reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but looks good to me overall. Please make sure @stocaaro and @thaddmt also review this

packages/api-graphql/src/GraphQLAPI.ts Outdated Show resolved Hide resolved
packages/api-graphql/src/GraphQLAPI.ts Outdated Show resolved Hide resolved
packages/core/src/libraryUtils.ts Outdated Show resolved Hide resolved
@yuhengshs yuhengshs marked this pull request as ready for review September 25, 2024 18:23
@yuhengshs yuhengshs requested review from a team as code owners September 25, 2024 18:23
@yuhengshs yuhengshs requested a review from a team as a code owner September 25, 2024 19:28
stocaaro
stocaaro previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@stocaaro stocaaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashika112
ashika112 previously approved these changes Sep 26, 2024
View reviewed changes
@yuhengshs yuhengshs dismissed stale reviews from ashika112 and stocaaro via 40d8bdb September 26, 2024 21:09
ashika112
ashika112 previously approved these changes Sep 27, 2024
View reviewed changes
cshfang
cshfang reviewed Sep 27, 2024
View reviewed changes
packages/core/src/Platform/types.ts Outdated Show resolved Hide resolved
packages/api-graphql/package.json Outdated Show resolved Hide resolved
packages/api-graphql/src/GraphQLAPI.ts Outdated Show resolved Hide resolved
packages/api-graphql/__tests__/GraphQLAPI.test.ts Show resolved Hide resolved
@yuhengshs yuhengshs force-pushed the yuhengsh-feat/add-granular-user-agent branch from 3578078 to 2885249 Compare September 27, 2024 21:03
@yuhengshs yuhengshs force-pushed the yuhengsh-feat/add-granular-user-agent branch 3 times, most recently from 9981c0c to 3996d60 Compare September 30, 2024 23:26
@yuhengshs yuhengshs force-pushed the yuhengsh-feat/add-granular-user-agent branch from 83b9872 to c1078f9 Compare September 30, 2024 23:48
@yuhengshs yuhengshs merged commit 6891c04 into aws-amplify:main Oct 1, 2024
30 checks passed
@yuhengshs yuhengshs deleted the yuhengsh-feat/add-granular-user-agent branch October 1, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashika112 ashika112 ashika112 approved these changes

@stocaaro stocaaro stocaaro approved these changes

@cshfang cshfang cshfang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuhengshs @cshfang @stocaaro @ashika112