chore(amplify_analytics): switch to federated plugins#1378
chore(amplify_analytics): switch to federated plugins#1378fjnoyp merged 12 commits intoaws-amplify:mainfrom fjnoyp:federated/analytics
Conversation
|
I'm not sure why so many of these files are showing up as new. Did you use Update: actually it looks like you may have committed some files from the older analyics directory (i.e. outside of the _plugin directory)? Potentially some auto generated stuff? |
packages/amplify_analytics_pinpoint_plugin/amplify_analytics_pinpoint/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint/example/.idea/codeStyles/Project.xml
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint/example/android/.idea/codeStyles/Project.xml
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint/example/ios/Podfile
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_android/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_android/example/README.md
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_android/example/lib/main.dart
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_android/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_ios/example/.idea/codeStyles/Project.xml
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_ios/example/ios/Podfile
Outdated
Show resolved
Hide resolved
packages/analytics/amplify_analytics_pinpoint_ios/example/lib/main.dart
Outdated
Show resolved
Hide resolved
| @@ -9,6 +9,8 @@ environment: | |||
|
|
|||
| dependencies: | |||
There was a problem hiding this comment.
I can't leave a comment on the correct line, but on line 4 the homepage will need to be updated.
- https://github.com/aws-amplify/amplify-flutter/tree/main/packages/amplify_analytics_pinpoint
+ https://github.com/aws-amplify/amplify-flutter/tree/main/packages/analytics/amplify_analytics_pinpointThis will unfortunately make pub analysis fail temporarily because the new URL will return a 404. Once the PR is merged, the URL will return a 200 and pub analysis will pass. The is the change @haverchuck made in #1424 for auth.
We will just have to merge this PR with one failing CI step. We should confirm that the homepage change is the only reason it is failing though.
There was a problem hiding this comment.
This comment applies to the storage PR as well by the way.
Both analytics and storage are scoring 110/120 on their pub score, which is passing in CI. With the homepage change, they will start scoring 100/120, which will fail in CI. If they score below 100, then we should figure out why before merging.
We should also keep an eye on the post-merge CI run to confirm it passes after this merges.
There was a problem hiding this comment.
Thanks sounds good, updated homepage field in pubspec.yaml
|
@fjnoyp I think rebasing will help these analysis issues. |
* chore(amplify_analytics): switch to federated plugins
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.