fix: cli.json update on pull, E2E enhancements #5516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove extra 'src' from imports - add new methods to nexpect - add delay to flaky test for kinesis
|
This pull request introduces 1 alert when merging ce31f81 into 3dfcc53 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #5516 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 402 402
Lines 18043 18043
Branches 3388 3388
=======================================
Hits 10661 10661
Misses 6743 6743
Partials 639 639 Continue to review full report at Codecov.
|
ammarkarachi
approved these changes
Oct 8, 2020
r0zar
pushed a commit
to r0zar/amplify-cli
that referenced
this pull request
Nov 19, 2020
r0zar
pushed a commit
to r0zar/amplify-cli
that referenced
this pull request
Nov 19, 2020
* chore(amplify-e2e-core): cleanup, new nexpect methods - remove extra 'src' from imports - add new methods to nexpect - add delay to flaky test for kinesis * fix: handle cli.json copy upon pull to empty dir * chore: fix lgtm warning * fix: nexpect params check for push
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
fix: handle cli.json copy upon pull to empty dir
chore(amplify-e2e-core): cleanup, new nexpect methods
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.