chore: Refactored secret manager and static data for credential rotator#88
Merged
chore: Refactored secret manager and static data for credential rotator#88
Conversation
palpatim
approved these changes
May 4, 2021
| @@ -0,0 +1,12 @@ | |||
| import os | |||
Member
There was a problem hiding this comment.
Quibble (not a "complaint", but more than a "nit") -- this isn't static data, it's being retrieved from a Lambda env var. Maybe lambda_env_var_data_source.py and retrieve_lambda_env_var_value?
Unless I'm misunderstanding the purpose?
palpatim
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.