Skip to content

Conversation

@svidgen
Copy link
Member

@svidgen svidgen commented May 15, 2025

Description of changes

#3270 adds the @aws_iam directive to graphql custom types so they can be used in custom operations under the IAM auth mode. However, the change also inadvertently adds the directive to graphql interface types, which is incorrect. Interfaces can't have these directives applied to them.

This change fixes that.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@svidgen
Copy link
Member Author

svidgen commented May 15, 2025

sobolk
sobolk previously approved these changes May 15, 2025
@svidgen
Copy link
Member Author

svidgen commented May 15, 2025

@svidgen svidgen marked this pull request as ready for review May 15, 2025 20:03
@svidgen svidgen requested a review from a team as a code owner May 15, 2025 20:03
@svidgen svidgen merged commit 5b7f4c3 into main May 15, 2025
8 checks passed
@svidgen svidgen deleted the wirejs/fix-iam-directive-on-interfaces-v2 branch May 15, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants