test: add additional migration validation test cases #2792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
finish-validation-e2e
branch
from
7ce7921 to
b3c5718
Compare
palpatim
reviewed
Aug 21, 2024
| // The test definitions include a schema, overrides, and the expected error messages. | ||
| const testCases = ['extraGSIOnGen2', 'billingMode']; | ||
| const getTestDefinition = (testCaseName: string): [TestDefinition, string, string[]] => { | ||
| const testCases = [ |
Member
There was a problem hiding this comment.
Could you derive this with Object.keys(testDefinitions)?
Contributor
Author
There was a problem hiding this comment.
I'm going to refactor this further since I now realize that the test definition is the same for each test.
palpatim
approved these changes
Aug 21, 2024
phani-srikar
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.