Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedupe environment variables in amplify env type generator #2153

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

ykethan
Copy link
Member

@ykethan ykethan commented Oct 25, 2024

Problem

Issue number, if available:
#2074

Changes

Uses Set to dedupe env variables
adds test to check for duplicate variables

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ykethan ykethan requested a review from a team as a code owner October 25, 2024 17:53
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 56595a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend-function Patch
@aws-amplify/backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sobolk
sobolk previously approved these changes Oct 25, 2024
rtpascual
rtpascual previously approved these changes Oct 25, 2024
@ykethan ykethan dismissed stale reviews from rtpascual and sobolk via 9ff00cb October 25, 2024 19:05
@ykethan ykethan merged commit 601a2c1 into aws-amplify:main Oct 25, 2024
40 checks passed
@ykethan ykethan deleted the env-gen-type-update branch October 25, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants