Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events archives for "upcoming" not showing "in progress" Events #225

Closed
JJJ opened this issue Jul 19, 2021 · 4 comments
Closed

Events archives for "upcoming" not showing "in progress" Events #225

JJJ opened this issue Jul 19, 2021 · 4 comments
Assignees
@JJJ
Labels
component-theme Theme code workflow-has-ticket
Milestone
2.2.3

Comments

@JJJ
Copy link
Contributor

JJJ commented Jul 19, 2021

Reported through HelpScout here: https://secure.helpscout.net/conversation/1570570616/189495?folderId=3659659

Events starting in the past but ending in the future do not appear in either upcoming or past archive views.

For lack of anything else, I'd call these "in progress" Events, and Sugar Calendar currently has no special handling for them.

In progress Events being totally missing was partially addressed in #44, only for widgets and shortcodes. Creating this issue to document the problem and milestone it for the 2.2.2 release.
@JJJ JJJ added this to the 2.2.2 milestone Jul 19, 2021
@JJJ JJJ self-assigned this Jul 19, 2021
@JJJ
Copy link
Contributor Author

JJJ commented Jul 19, 2021

The problem code is here:

https://github.com/sugarcalendar/core/blob/7155c47aa1925c35ec33729ee55d31ba6629d21e/sugar-calendar/includes/post/query-filters.php#L115-L124

Swapping out {$alias}.start for {$alias}.end will ensure that these "in progress" Events continue to correctly appear in the past view, while also showing in the upcoming view.

I also think we should add support for an in-progress view option while we are here.

@JiveDig
Copy link

JiveDig commented Jul 20, 2021

Coming from #44 I still see this issue as well. Events that are in progress are not showing in "upcoming". An in-progress option for the shortcode/function would be great, but I'm open to whatever you decide. Thanks brother!

@JJJ JJJ mentioned this issue Jul 22, 2021
Merged
JJJ added a commit that referenced this issue Jul 23, 2021
@JJJ
Widgets: add support for WordPress 5.8, and "in-progress" status.
9d12362 
This commit ensures that in-progress Events appear in "upcoming" archive views, to match the shortcode behavior.

It also updates some old strings, adds classes to Event filter links, and adds a new "in-progress" filter.

Fixes #225.
@JJJ JJJ closed this as completed Jul 23, 2021
@JiveDig
Copy link

JiveDig commented Dec 1, 2021

Hey @JJJ sorry to bump this, but I have 2 questions pertaining to this...

  1. The shortcode/function should be allowed to pass multiple statuses. We have a need where we want "upcoming" AND "in-progress" in the same list.
  2. The [sc_events_list] shortcode docs should get updated to show this in-progress option as well. https://docs.sugarcalendar.com/article/196-displaying-event-lists

I can open a new issue for 1 if it's something y'all would want to consider.

@JJJ
Copy link
Contributor Author

JJJ commented Dec 1, 2021

@JiveDig Sure, sounds good to me!

@JiveDig JiveDig mentioned this issue Dec 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JJJ JJJ

Labels
component-theme Theme code workflow-has-ticket
Projects
None yet
Milestone
2.2.3
Development

No branches or pull requests
2 participants
@JJJ @JiveDig