Issue/227 - Add widgets.php to Legacy loader (#228)

* Legacy: add missing $order parameter to sc_get_events_list docs
* Legacy: rename $today variable to $now in sc_get_events_list().
* Load: add widgets.php to admin pages that load legacy files.

This change circumvents a fatal error with WordPress 5.8 by ensuring that all legacy functions are available in the new widgets UI.

sugar-calendar/includes/themes/legacy/events-list.php

@@ -19,13 +19,14 @@
  * @param null $category
  * @param int $number
  * @param array $show
+ * @param string $order
  *
  * @return string
  */
 function sc_get_events_list( $display = 'upcoming', $category = null, $number = 5, $show = array(), $order = '' ) {
 
 	// Get today, to query before/after
-	$today = sugar_calendar_get_request_time( 'mysql' );
+	$now = sugar_calendar_get_request_time( 'mysql' );
 
 	// Mutate order to uppercase if not empty
 	if ( ! empty( $order ) ) {
@@ -51,7 +52,7 @@ function sc_get_events_list( $display = 'upcoming', $category = null, $number =
 			'number'      => $number,
 			'end_query'   => array(
 				'inclusive' => true,
-				'after'     => $today
+				'after'     => $now
 			)
 		);
 
@@ -65,7 +66,7 @@ function sc_get_events_list( $display = 'upcoming', $category = null, $number =
 			'number'      => $number,
 			'end_query'   => array(
 				'inclusive' => true,
-				'before'    => $today
+				'before'    => $now
 			)
 		);
 

sugar-calendar/sugar-calendar.php

@@ -398,9 +398,24 @@ private function include_admin() {
 		// Legacy
 		require_once SC_PLUGIN_DIR . 'includes/admin/settings.php';
 
-		// Maybe include front-end on AJAX or add/edit post page to load
-		// shortcodes, widgets, and more...
-		if ( wp_doing_ajax() || ( ! empty( $GLOBALS['pagenow'] ) && ( 'post.php' === $GLOBALS['pagenow'] ) ) ) {
+		// Maybe include front-end on AJAX, add/edit post page, or widgets, to
+		// load all shortcodes, widgets, assets, etc...
+		if (
+
+			// Admin AJAX
+			wp_doing_ajax()
+
+			||
+
+			// Specific admin pages
+			(
+				! empty( $GLOBALS['pagenow'] )
+
+				&&
+
+				in_array( $GLOBALS['pagenow'], array( 'post.php', 'widgets.php' ), true )
+			)
+		) {
 			$this->include_frontend();
 		}
 	}
@@ -417,7 +432,6 @@ private function include_frontend() {
 		require_once SC_PLUGIN_DIR . 'includes/themes/legacy/calendar.php';
 		require_once SC_PLUGIN_DIR . 'includes/themes/legacy/event-display.php';
 		require_once SC_PLUGIN_DIR . 'includes/themes/legacy/events-list.php';
-		require_once SC_PLUGIN_DIR . 'includes/themes/legacy/scripts.php';
 	}
 
 	/**