Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testID prop #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

swizes
Copy link

@swizes swizes commented Jul 3, 2023

With the changes now the QR SVG component accepts testID prop, so we can assert the visibility of the QR Code in unit/e2e tests.

Example usage:

    <QRCode
      value="Just some string value"
      logo={logoFromFile}
      testID={'SomeTestID'}
    />

@professorkolik
Copy link

@awesomejerry Any chance to merge this?

@@ -82,7 +82,8 @@ const QRCode = ({
linearGradient = ['rgb(255,0,0)', 'rgb(0,255,255)'],
ecl = 'M',
getRef,
onError
onError,
testID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added testID, but you didn't pass it to the Svg component.
So basically this code won't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants