Skip to content

Commit

Permalink
Fix span includes into function validation (gfx-rs#1500)
Browse files Browse the repository at this point in the history
  • Loading branch information
kvark authored Nov 1, 2021
1 parent 9d2b357 commit 323999f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/lazy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
with:
name: code-coverage-report
path: cobertura.xml

parse-dota2:
name: Parse Dota2 shaders
runs-on: ubuntu-latest
Expand All @@ -44,6 +45,7 @@ jobs:
run: cargo build --release --bin naga
- name: Convert shaders
run: for file in data/*.spv ; do echo "Translating" ${file} && target/release/naga --validate 27 ${file} ${file}.metal; done

parse-vulkan-tutorial-shaders:
name: Parse Sascha Willems Vulkan tutorial shaders
runs-on: ubuntu-latest
Expand Down Expand Up @@ -76,6 +78,7 @@ jobs:
echo "Result: $(expr $FILE_COUNT - $SUCCESS_RESULT_COUNT) / $FILE_COUNT" > counter
done
cat counter
dneto0_spirv-samples:
name: Parse dneto0 spirv-samples
runs-on: ubuntu-latest
Expand Down Expand Up @@ -149,15 +152,21 @@ jobs:
echo "Result: $(expr $FILE_COUNT - $SUCCESS_RESULT_COUNT) / $FILE_COUNT" > counter
done
cat counter
check_snapshots_without_validation:
name: Check snapshots (without validation)
check-snapshots-extra:
name: Check snapshots (validated or not)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
- uses: actions-rs/cargo@v1
name: Test minimal (without span)
with:
command: test
args: --features validate -p naga
- uses: actions-rs/cargo@v1
name: Test all (without validation)
with:
Expand Down
2 changes: 1 addition & 1 deletion src/valid/function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use super::{
ExpressionError, FunctionInfo, ModuleInfo,
};
use crate::span::WithSpan;
#[cfg(feature = "span")]
#[cfg(feature = "validate")]
use crate::span::{AddSpan as _, MapErrWithSpan as _};

#[cfg(feature = "validate")]
Expand Down

0 comments on commit 323999f

Please sign in to comment.