-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: format void and generic types
#735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--- - *Fixes #732*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the type formatting functionality to better handle void and generic type parameters. The changes improve the readability and accuracy of type formatting by using simplified representations for these special cases.
Key changes:
- Added special formatting for
voidtypes to display as "void" instead of the full type name - Added special formatting for generic parameters to display only their parameter name (e.g., "T" instead of "IEnumerable<>.T")
- Updated test expectations to reflect the simplified generic parameter formatting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Source/aweXpect.Core/Formatting/ValueFormatters.Type.cs |
Added special handling for void types and generic parameters in the FormatType method |
Tests/aweXpect.Core.Tests/Formatting/ValueFormatters.TypeTests.cs |
Updated test expectations for generic parameters and added comprehensive tests for both void and generic parameter formatting |
Test Results 14 files - 24 14 suites - 24 3m 8s ⏱️ -5s Results for commit 4d3fa0c. ± Comparison against base commit 9fa4854. This pull request removes 1556 and adds 1535 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
🚀 Benchmark ResultsDetails
|
👽 Mutation ResultsaweXpectDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0aweXpect.CoreDetails
The final mutation score is 96.61%Coverage Thresholds: high:80 low:60 break:0 |
|
…735) by Valentin Breuß
…735) by Valentin Breuß
|
This is addressed in release v2.22.0. |



This PR enhances the type formatting functionality to better handle
voidand generic type parameters. The changes improve the readability and accuracy of type formatting by using simplified representations for these special cases.Key changes:
voidtypes to display as "void" instead of the full type namevoidand generic types #732