feat: allow verifying method setup calls by vbreuss · Pull Request #493 · aweXpect/Mockolate

vbreuss · 2026-02-28T12:50:53Z

Adds a new verification surface that allows asserting how often a specific method setup (not just a method signature) was invoked, by introducing a reusable “method match” abstraction and wiring it through verification.

Key Changes:

Introduces IMethodMatch + match implementations (MethodParameterMatch, MethodParametersMatch) and threads them through MockRegistration.Method(...).
Adds MockExtensions.InvokedSetup(...) to verify invocations for a given setup.
Updates tests (and API snapshots) to cover the new verification behavior and the revised verification plumbing.

Fixes Use setup to verify invocations of this setup #492

Copilot

Pull request overview

Adds a new verification surface that allows asserting how often a specific method setup (not just a method signature) was invoked, by introducing a reusable “method match” abstraction and wiring it through verification.

Changes:

Introduces IMethodMatch + match implementations (MethodParameterMatch, MethodParametersMatch) and threads them through MockRegistration.Method(...).
Adds MockExtensions.InvokedSetup(...) to verify invocations for a given setup.
Updates tests (and API snapshots) to cover the new verification behavior and the revised verification plumbing.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Tests/Mockolate.Tests/MockMethods/VerifyInvokedTests.cs	Adds coverage for verifying invocations of a method setup.
Tests/Mockolate.Tests/MockMethods/SetupMethodTests.cs	Updates a test helper subclass to satisfy the new `MethodSetup` ctor requirements.
Tests/Mockolate.Tests/MockMethods/InteractionsTests.cs	Refactors interaction verification tests to use `MethodParameterMatch`.
Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt	Updates API snapshot for new/changed public APIs.
Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt	Updates API snapshot for new/changed public APIs.
Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt	Updates API snapshot for new/changed public APIs.
Source/Mockolate/Setup/VoidMethodSetup.cs	Supplies `IMethodMatch` to the `MethodSetup` base via new match structs.
Source/Mockolate/Setup/ReturnMethodSetup.cs	Supplies `IMethodMatch` to the `MethodSetup` base via new match structs.
Source/Mockolate/Setup/MethodSetup.cs	Converts `MethodSetup` to require an `IMethodMatch` and exposes it via `IVerifiableMethodSetup`.
Source/Mockolate/Setup/MethodParametersMatch.cs	Adds match type for `IParameters`-based comparisons.
Source/Mockolate/Setup/MethodParameterMatch.cs	Adds match type for `NamedParameter[]`-based comparisons.
Source/Mockolate/Setup/Interfaces.MethodSetup.cs	Introduces `IMethodSetup`/`IVerifiableMethodSetup` and makes return-setup interfaces extend `IMethodSetup`.
Source/Mockolate/Setup/IMethodMatch.cs	Adds the matching abstraction used by verification.
Source/Mockolate/MockRegistration.Verify.cs	Replaces method verification overloads with an `IMethodMatch`-based overload.
Source/Mockolate/MockExtensions.cs	Adds `InvokedSetup(...)` extension for verifying setup invocations.
Source/Mockolate/Mock.Verify.cs	Updates internal verification helpers to use the new match types.
Source/Mockolate.SourceGenerators/Sources/Sources.MethodSetups.cs	Updates generated setup classes to call the new `MethodSetup` base ctor.

github-actions · 2026-02-28T12:56:21Z

Test Results

21 files ± 0 21 suites ±0 6m 13s ⏱️ + 1m 2s
2 755 tests + 26 2 754 ✅ + 26 1 💤 ±0 0 ❌ ±0
18 502 runs +182 18 501 ✅ +182 1 💤 ±0 0 ❌ ±0

Results for commit fc7600a. ± Comparison against base commit 18cd76b.

♻️ This comment has been updated with latest results.

github-actions · 2026-02-28T13:03:52Z

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)

AMD EPYC 7763 2.61GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.103

[Host] : .NET 10.0.3 (10.0.3, 10.0.326.7603), X64 RyuJIT x86-64-v3
Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
Simple_Mockolate	1.623 μs	0.0133 μs	0.0118 μs	0.2460	-	4.04 KB
Simple_Moq	183.571 μs	1.2313 μs	1.1517 μs	0.4883	-	14.55 KB
Simple_NSubstitute	5.878 μs	0.0445 μs	0.0394 μs	0.5569	0.0076	9.14 KB
Simple_FakeItEasy	6.455 μs	0.0494 μs	0.0462 μs	0.4959	-	8.11 KB

sonarqubecloud · 2026-02-28T13:33:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Copilot · 2026-02-28T13:35:37Z

+		=> methodInvocation.Name.Equals(methodName) &&
+		   methodInvocation.Parameters.Length == parameters.Length &&
+		   !parameters
+			   .Where((parameter, i) => !parameter.Matches(methodInvocation.Parameters[i]))
+			   .Any();
+


MethodParameterMatch.Matches uses LINQ (Where(...).Any()) on each comparison, which adds iterator overhead in a potentially hot verification path. A simple indexed for loop (or All) would avoid the LINQ overhead while keeping the same semantics.

Suggested change

=> methodInvocation.Name.Equals(methodName) &&

methodInvocation.Parameters.Length == parameters.Length &&

!parameters

.Where((parameter, i) => !parameter.Matches(methodInvocation.Parameters[i]))

.Any();

{

if (!methodInvocation.Name.Equals(methodName))

{

return false;

}

if (methodInvocation.Parameters.Length != parameters.Length)

{

return false;

}

for (int index = 0; index < parameters.Length; index++)

{

if (!parameters[index].Matches(methodInvocation.Parameters[index]))

{

return false;

}

}

return true;

}

Copilot · 2026-02-28T13:35:38Z

 	/// <summary>
-	///     Counts the invocations of method <paramref name="methodName" /> with matching <paramref name="parameters" /> on the
-	///     <paramref name="subject" />.
+	///     Counts the invocations of methods matching the <paramref name="methodMatch" /> on the <paramref name="subject" />.
 	/// </summary>
-	public VerificationResult<T> Method<T>(T subject, string methodName, params NamedParameter[] parameters)
+	public VerificationResult<T> Method<T>(T subject, IMethodMatch methodMatch)
 		=> new(


MockRegistration.Method<T> is a public API, and (per the API snapshot updates) the overloads that accept (string methodName, params NamedParameter[]) / (string methodName, IParameters) were removed in favor of IMethodMatch. Consider keeping the old overloads (possibly [Obsolete]) and delegating them to the new overload to avoid a breaking change for consumers using MockRegistration directly.

Copilot · 2026-02-28T13:35:38Z

+	/// <inheritdoc cref="IVerifiableMethodSetup.GetMatch()" />
+	public IMethodMatch GetMatch()
+		=> methodMatch;


MethodParameterMatch/MethodParametersMatch are readonly structs but they’re typically passed/stored as IMethodMatch (e.g., MethodSetup(IMethodMatch methodMatch) / GetMatch()), which forces boxing allocations for each instance. If reducing allocations is a goal, consider making the match types sealed classes (or otherwise avoiding interface boxing).

github-actions · 2026-02-28T20:37:27Z

This is addressed in release v1.5.0.

feat: allow verifying method setup calls

f326857

vbreuss self-assigned this Feb 28, 2026

vbreuss added the enhancement New feature or request label Feb 28, 2026

Copilot AI review requested due to automatic review settings February 28, 2026 12:50

Copilot started reviewing on behalf of vbreuss February 28, 2026 12:51 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Fix sonar issues and simplify MethodSetup implementation

d055061

Copilot AI review requested due to automatic review settings February 28, 2026 13:29

Fix review issues

fc7600a

Copilot started reviewing on behalf of vbreuss February 28, 2026 13:29 View session

vbreuss enabled auto-merge (squash) February 28, 2026 13:29

vbreuss merged commit 64405fe into main Feb 28, 2026
16 checks passed

vbreuss deleted the topic/verify-method-setup branch February 28, 2026 13:35

Copilot AI reviewed Feb 28, 2026

View reviewed changes

vbreuss mentioned this pull request Feb 28, 2026

docs: document new features #501

Merged

github-actions Bot added the state: released The issue is released label Feb 28, 2026

dependabot Bot mentioned this pull request Mar 2, 2026

chore: Bump Mockolate from 1.4.1 to 1.5.0 aweXpect/aweXpect.Mockolate#71

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: allow verifying method setup calls#493

feat: allow verifying method setup calls#493
vbreuss merged 3 commits intomainfrom
topic/verify-method-setup

vbreuss commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Feb 28, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 28, 2026

Uh oh!

Copilot AI Feb 28, 2026

Uh oh!

Copilot AI Feb 28, 2026

Uh oh!

github-actions Bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-		=> methodInvocation.Name.Equals(methodName) &&
-		   methodInvocation.Parameters.Length == parameters.Length &&
-		   !parameters
-			   .Where((parameter, i) => !parameter.Matches(methodInvocation.Parameters[i]))
-			   .Any();
+	{
+		if (!methodInvocation.Name.Equals(methodName))
+		{
+			return false;
+		}
+		if (methodInvocation.Parameters.Length != parameters.Length)
+		{
+			return false;
+		}
+		for (int index = 0; index < parameters.Length; index++)
+		{
+			if (!parameters[index].Matches(methodInvocation.Parameters[index]))
+			{
+				return false;
+			}
+		}
+		return true;
+	}

Uh oh!

Conversation

vbreuss commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Benchmark Results

Uh oh!

sonarqubecloud Bot commented Feb 28, 2026

Quality Gate passed

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vbreuss commented Feb 28, 2026 •

edited

Loading

github-actions Bot commented Feb 28, 2026 •

edited

Loading

github-actions Bot commented Feb 28, 2026 •

edited

Loading