refactor: make HttpContentParameterWrapper public#481
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Makes HttpContentParameterWrapper part of the public API so consumers can build/reuse HTTP content parameter wrappers.
Changes:
- Promotes
HttpContentParameterWrapperfrom private topublic abstractand adds XML documentation. - Adjusts interface implementation details for matching and callback forwarding.
- Updates API snapshot expectations for netstandard2.0/net8.0/net10.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt | Updates API snapshot to include HttpContentParameterWrapper in public surface. |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt | Updates API snapshot to include HttpContentParameterWrapper in public surface. |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt | Updates API snapshot to include HttpContentParameterWrapper in public surface. |
| Source/Mockolate/Web/ItExtensions.HttpContent.cs | Makes HttpContentParameterWrapper public/abstract and forwards methods to an inner parameter. |
|
🚀 Benchmark ResultsDetails
|
|
This is addressed in release v1.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Makes
HttpContentParameterWrapperpart of the public API so consumers can build/reuse HTTP content parameter wrappers.Key Changes:
HttpContentParameterWrapperfrom private topublic abstractand adds XML documentation.IHttpRequestMessagePropertyParameterpublic #480