Skip to content

refactor: make HttpContentParameterWrapper public#481

Merged
vbreuss merged 1 commit intomainfrom
topic/make-HttpContentParameterWrapper-public
Feb 10, 2026
Merged

refactor: make HttpContentParameterWrapper public#481
vbreuss merged 1 commit intomainfrom
topic/make-HttpContentParameterWrapper-public

Conversation

@vbreuss
Copy link
Copy Markdown
Contributor

@vbreuss vbreuss commented Feb 10, 2026

Makes HttpContentParameterWrapper part of the public API so consumers can build/reuse HTTP content parameter wrappers.

Key Changes:

  • Promotes HttpContentParameterWrapper from private to public abstract and adds XML documentation.
  • Adjusts interface implementation details for matching and callback forwarding.
  • Updates API snapshot expectations for netstandard2.0/net8.0/net10.0.

@vbreuss vbreuss self-assigned this Feb 10, 2026
Copilot AI review requested due to automatic review settings February 10, 2026 21:41
@vbreuss vbreuss added the enhancement New feature or request label Feb 10, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes HttpContentParameterWrapper part of the public API so consumers can build/reuse HTTP content parameter wrappers.

Changes:

  • Promotes HttpContentParameterWrapper from private to public abstract and adds XML documentation.
  • Adjusts interface implementation details for matching and callback forwarding.
  • Updates API snapshot expectations for netstandard2.0/net8.0/net10.0.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt Updates API snapshot to include HttpContentParameterWrapper in public surface.
Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt Updates API snapshot to include HttpContentParameterWrapper in public surface.
Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt Updates API snapshot to include HttpContentParameterWrapper in public surface.
Source/Mockolate/Web/ItExtensions.HttpContent.cs Makes HttpContentParameterWrapper public/abstract and forwards methods to an inner parameter.

Comment thread Source/Mockolate/Web/ItExtensions.HttpContent.cs
Comment thread Source/Mockolate/Web/ItExtensions.HttpContent.cs
Comment thread Source/Mockolate/Web/ItExtensions.HttpContent.cs
@vbreuss vbreuss enabled auto-merge (squash) February 10, 2026 21:44
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Test Results

    21 files  ±0      21 suites  ±0   5m 8s ⏱️ -24s
 2 727 tests ±0   2 726 ✅ ±0  1 💤 ±0  0 ❌ ±0 
18 307 runs  ±0  18 306 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 62fb9d5. ± Comparison against base commit 9131dcc.

@vbreuss vbreuss merged commit 01cf563 into main Feb 10, 2026
12 checks passed
@vbreuss vbreuss deleted the topic/make-HttpContentParameterWrapper-public branch February 10, 2026 21:46
@github-actions
Copy link
Copy Markdown

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.45GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.103
[Host] : .NET 10.0.3 (10.0.3, 10.0.326.7603), X64 RyuJIT x86-64-v3

Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15
LaunchCount=1 WarmupCount=10

Method Mean Error StdDev Gen0 Gen1 Allocated
Simple_Mockolate 1.590 μs 0.0212 μs 0.0199 μs 0.2270 - 3.73 KB
Simple_Moq 169.780 μs 0.5602 μs 0.4678 μs 0.4883 - 14.55 KB
Simple_NSubstitute 5.806 μs 0.0542 μs 0.0507 μs 0.5569 0.0076 9.14 KB
Simple_FakeItEasy 6.606 μs 0.0351 μs 0.0311 μs 0.4959 - 8.11 KB

@github-actions
Copy link
Copy Markdown

This is addressed in release v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider making IHttpRequestMessagePropertyParameter public

2 participants