fix: persist indexer values when return setup is conditional#409
Merged
fix: persist indexer values when return setup is conditional#409
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the indexer setup mechanism to ensure that indexer values persist correctly when return setups are conditional (using modifiers like OnlyOnce(), For(), or When()). Previously, when conditional setups expired or didn't match, the mock would incorrectly return default values instead of preserving the last value that was set.
Changes:
- Refactored indexer value retrieval logic to always consult the backing storage before applying conditional return setups
- Removed the now-obsolete
HasReturnCalls()method from the indexer setup infrastructure - Added comprehensive test coverage to verify that indexer values persist correctly across various scenarios with conditional setups
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Mockolate.Tests/SetupExtensionsTests.cs | Added new test cases to verify indexer value persistence with OnlyOnce() and For() modifiers |
| Tests/Mockolate.Tests/MockProperties/SetupPropertyTests.ReturnsThrowsTests.cs | Added tests for property value persistence with conditional setups and updated predicate range |
| Tests/Mockolate.Tests/MockIndexers/SetupIndexerTests.ReturnsThrowsTests.cs | Added comprehensive test suite with nested classes and new test helper class to verify indexer behavior with base values |
| Tests/Mockolate.Tests/MockIndexers/SetupIndexerTests.cs | Removed obsolete HasReturnCalls() override from test mock implementation |
| Tests/Mockolate.ExampleTests/ExampleTests.cs | Added example test demonstrating mock usage (appears to be development/debugging code) |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_*.txt | Updated API surface expectations to reflect removal of HasReturnCalls() method |
| Source/Mockolate/Setup/Interfaces.IndexerSetup.cs | Removed HasReturnCalls() method from interface |
| Source/Mockolate/Setup/IndexerSetupResult.cs | Refactored to retrieve indexer value before applying getter callback |
| Source/Mockolate/Setup/IndexerSetup.cs | Removed HasReturnCalls() method and all its implementations |
| Source/Mockolate.SourceGenerators/Sources/Sources.IndexerSetups.cs | Updated source generator to stop emitting HasReturnCalls() method |
vbreuss
force-pushed
the
topic/fix-indexer-value-persistence
branch
from
bc015a8 to
4d09cc5
Compare
🚀 Benchmark ResultsDetails
|
|
Test Results 21 files ± 0 21 suites ±0 5m 29s ⏱️ -44s Results for commit 4d09cc5. ± Comparison against base commit ab6f6ed. This pull request removes 24 and adds 42 tests. Note that renamed tests count towards both. |
|
This is addressed in release v1.0.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the indexer setup mechanism to ensure that indexer values persist correctly when return setups are conditional (using modifiers like
OnlyOnce(),For(), orWhen()). Previously, when conditional setups expired or didn't match, the mock would incorrectly return default values instead of preserving the last value that was set.Key changes:
HasReturnCalls()method from the indexer setup infrastructure