Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the string representation of Match.* methods to include the Match. prefix, making the output more explicit and clear about the origin of these matcher methods.
Key changes:
- Updated
ToString()implementations inMatch.AnyParameters(),Match.Parameters(), andMatch.WithDefaultParameters()to include the "Match." prefix - Updated corresponding test assertions to expect the new string format with the prefix
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Mockolate/Match.AnyParameters.cs | Updated ToString() to return "Match.AnyParameters()" instead of "AnyParameters()" |
| Source/Mockolate/Match.Parameters.cs | Updated ToString() to return "Match.Parameters(...)" instead of "Parameters(...)" |
| Source/Mockolate/Match.WithDefaultParameters.cs | Updated ToString() to return "Match.WithDefaultParameters()" instead of "WithDefaultParameters()" |
| Tests/Mockolate.Tests/MatchTests.AnyParametersTests.cs | Updated test expectation to match new string format |
| Tests/Mockolate.Tests/MatchTests.ParametersTests.cs | Updated test expectation to match new string format |
| Tests/Mockolate.Tests/MatchTests.WithDefaultParametersTests.cs | Updated test expectation to match new string format |
| Tests/Mockolate.Tests/MockMethods/SetupMethodTests.cs | Updated multiple test assertions to expect "Match.AnyParameters()" and added new tests for string representation with AnyParameters() |
🚀 Benchmark ResultsDetails
|
|
Test Results 14 files ± 0 14 suites ±0 5m 40s ⏱️ +24s Results for commit 917029d. ± Comparison against base commit a561d1d. This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. |
|
This is addressed in release v0.46.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the string representation of
Match.*methods to include theMatch.prefix, making the output more explicit and clear about the origin of these matcher methods.Key changes:
ToString()implementations inMatch.AnyParameters(),Match.Parameters(), andMatch.WithDefaultParameters()to include the "Match." prefix