Skip to content

Comments

refactor: remove dead code in delegate source generation#313

Merged
vbreuss merged 1 commit intomainfrom
topic/remove-dead-code-delegate-source-generation
Dec 13, 2025
Merged

refactor: remove dead code in delegate source generation#313
vbreuss merged 1 commit intomainfrom
topic/remove-dead-code-delegate-source-generation

Conversation

@vbreuss
Copy link
Contributor

@vbreuss vbreuss commented Dec 13, 2025

This PR removes dead code related to delegate source generation and consolidates some test methods. The main focus is on cleaning up unused methods in the source generator and reorganizing test cases for better structure.

Key Changes

  • Removed unused delegate-related source generation methods (AppendDelegateExtensions, AppendMockExtensions)
  • Add missing source generation tests
  • Eliminated unused helper method GetAllClasses() from MockClass
  • Reorganized test methods by moving several tests to earlier positions in the test file

@vbreuss vbreuss self-assigned this Dec 13, 2025
@vbreuss vbreuss added the coverage Additional tests for edge cases or improvement of test coverage label Dec 13, 2025
Copilot AI review requested due to automatic review settings December 13, 2025 12:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes dead code related to delegate source generation and consolidates some test methods. The main focus is on cleaning up unused methods in the source generator and reorganizing test cases for better structure.

Key Changes

  • Removed unused delegate-related source generation methods (AppendDelegateExtensions, AppendMockExtensions)
  • Eliminated unused helper method GetAllClasses() from MockClass
  • Reorganized test methods by moving several tests to earlier positions in the test file

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Tests/Mockolate.SourceGenerators.Tests/Sources/MockClassTests.cs Added test for special types support in mock generation
Tests/Mockolate.SourceGenerators.Tests/Sources/ForMockTests.ImplementClassTests.cs Reorganized existing tests by moving them earlier in the file and added new tests for ref/out parameters and Span support
Source/Mockolate.SourceGenerators/Sources/Sources.ForMock.cs Simplified XML documentation by removing iteration over additional implementations
Source/Mockolate.SourceGenerators/Sources/Sources.ForMock.CombinationExtensions.cs Removed delegate extension generation methods and simplified the extension generation logic
Source/Mockolate.SourceGenerators/MockGenerator.cs Updated method call to pass distinct additional implementations as parameter
Source/Mockolate.SourceGenerators/Entities/MockClass.cs Removed unused GetAllClasses() helper method

@vbreuss vbreuss enabled auto-merge (squash) December 13, 2025 12:41
@vbreuss vbreuss disabled auto-merge December 13, 2025 12:42
@vbreuss vbreuss enabled auto-merge (squash) December 13, 2025 12:42
@sonarqubecloud
Copy link

@github-actions
Copy link

Test Results

    14 files  ±0      14 suites  ±0   4m 46s ⏱️ +26s
 1 673 tests +2   1 672 ✅ +2  1 💤 ±0  0 ❌ ±0 
11 168 runs  +6  11 167 ✅ +6  1 💤 ±0  0 ❌ ±0 

Results for commit d8fcb07. ± Comparison against base commit 84c7460.

@vbreuss vbreuss merged commit 91bec3d into main Dec 13, 2025
12 checks passed
@vbreuss vbreuss deleted the topic/remove-dead-code-delegate-source-generation branch December 13, 2025 12:47
@github-actions
Copy link

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.101
[Host] : .NET 10.0.1 (10.0.1, 10.0.125.57005), X64 RyuJIT x86-64-v3

Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15
LaunchCount=1 WarmupCount=10

Method Mean Error StdDev Gen0 Gen1 Allocated
Simple_Mockolate 1.519 μs 0.0171 μs 0.0160 μs 0.2232 - 3.66 KB
Simple_Moq 178.970 μs 0.5043 μs 0.4211 μs 0.4883 - 14.55 KB
Simple_NSubstitute 6.049 μs 0.0143 μs 0.0119 μs 0.5569 0.0076 9.14 KB
Simple_FakeItEasy 6.768 μs 0.0173 μs 0.0162 μs 0.4959 - 8.11 KB

@github-actions
Copy link

This is addressed in release v0.45.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coverage Additional tests for edge cases or improvement of test coverage state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant