Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses SonarQube/SonarCloud code quality issues by suppressing S3218 warnings (inner class members shadowing outer class members) across multiple files in the It class implementation. The changes involve adding pragma directives to disable and restore the S3218 warning, and includes a minor refactoring of the ParameterEqualsMatch class to use primary constructor syntax.
Key changes:
- Added S3218 pragma warning suppressions to all partial class files in the
Itclass family - Refactored
ParameterEqualsMatch<T>to use C# 12 primary constructor syntax - Added ReSharper comment to suppress localization warning for an error message
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Mockolate/It.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.Matches.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsTrue.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsSpan.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsRef.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsReadOnlySpan.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsOut.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsNull.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsInRange.cs | Added S3218 warning suppression pragmas and ReSharper comment |
| Source/Mockolate/It.IsFalse.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.IsAny.cs | Added S3218 warning suppression pragmas |
| Source/Mockolate/It.Is.cs | Added S3218 warning suppression pragmas and refactored ParameterEqualsMatch<T> to primary constructor |
🚀 Benchmark ResultsDetails
|
|
|
This is addressed in release v0.44.0. |



This PR addresses SonarQube/SonarCloud code quality issues by suppressing S3218 warnings (inner class members shadowing outer class members) across multiple files in the
Itclass implementation. The changes involve adding pragma directives to disable and restore the S3218 warning, and includes a minor refactoring of theParameterEqualsMatchclass to use primary constructor syntax.Key changes:
Itclass family