Skip to content

Commit

Permalink
fix pipewire portal by removing blocks parameter
Browse files Browse the repository at this point in the history 
When this parameter is enabled than pipewire reports the following error:

**HyperHDR:**
Pipewire: updated parameters 0
Pipewire: core error reported
Pipewire: stream reports error 'error alloc buffers: Invalid argument'
Pipewire: core reports error 'error alloc buffers: Invalid argument'

**Pipewire:**
pipewire[1850759]: pw.context: params Spa:Enum:ParamId:Buffers: 1:0 Invalid argument (input param)
pipewire[1850759]: pw.context: Object: size 168, type Spa:Pod:Object:Param:Buffers (262148), id Spa:Enum:ParamId:Buffers (5)
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:size (3), flags 00000000
pipewire[1850759]: pw.context:     Int 33177600
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:buffers (1), flags 00000000
pipewire[1850759]: pw.context:     Choice: type Spa:Enum:Choice:Range, flags 00000000 28 4
pipewire[1850759]: pw.context:       Int 16
pipewire[1850759]: pw.context:       Int 2
pipewire[1850759]: pw.context:       Int 16
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:stride (4), flags 00000000
pipewire[1850759]: pw.context:     Int 15360
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:dataType (6), flags 00000000
pipewire[1850759]: pw.context:     Choice: type Spa:Enum:Choice:Flags, flags 00000000 20 4
pipewire[1850759]: pw.context:       Int 12
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:blocks (2), flags 00000000
pipewire[1850759]: pw.context:     Int 3
pipewire[1850759]: pw.context: params Spa:Enum:ParamId:Buffers: 0:0 Invalid argument (output param)
pipewire[1850759]: pw.context: Object: size 216, type Spa:Pod:Object:Param:Buffers (262148), id Spa:Enum:ParamId:Buffers (5)
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:buffers (1), flags 00000000
pipewire[1850759]: pw.context:     Choice: type Spa:Enum:Choice:Range, flags 00000000 28 4
pipewire[1850759]: pw.context:       Int 2
pipewire[1850759]: pw.context:       Int 2
pipewire[1850759]: pw.context:       Int 16
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:blocks (2), flags 00000000
pipewire[1850759]: pw.context:     Int 1
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:size (3), flags 00000000
pipewire[1850759]: pw.context:     Int 33177600
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:stride (4), flags 00000000
pipewire[1850759]: pw.context:     Choice: type Spa:Enum:Choice:Range, flags 00000000 28 4
pipewire[1850759]: pw.context:       Int 15360
pipewire[1850759]: pw.context:       Int 15360
pipewire[1850759]: pw.context:       Int 2147483647
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:align (5), flags 00000000
pipewire[1850759]: pw.context:     Int 16
pipewire[1850759]: pw.context:   Prop: key Spa:Pod:Object:Param:Buffers:BlockInfo:dataType (6), flags 00000000
pipewire[1850759]: pw.context:     Choice: type Spa:Enum:Choice:Flags, flags 00000000 20 4
pipewire[1850759]: pw.context:       Int 14
pipewire[1850759]: pw.link: (103.0.0 -> 79.0.0) allocating -> error (error alloc buffers: Invalid argument) (ready-ready)

This happens with pipewire 1.0.0 and pipewire master.
  • Loading branch information
@Mic92
Mic92 committed Jan 6, 2024
1 parent 558c7e0 commit 2d031d6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sources/grabber/pipewire/PipewireHandler.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,6 @@ void PipewireHandler::onParamsChanged(uint32_t id, const struct spa_pod* param)
updatedParams[0] = (spa_pod*)(spa_pod*)spa_pod_builder_add_object(&updateBufferBuilder,
SPA_TYPE_OBJECT_ParamBuffers, SPA_PARAM_Buffers,
SPA_PARAM_BUFFERS_buffers, SPA_POD_CHOICE_RANGE_Int(2, 2, 16),
SPA_PARAM_BUFFERS_blocks, SPA_POD_Int(1),
SPA_PARAM_BUFFERS_size, SPA_POD_Int(size),
SPA_PARAM_BUFFERS_stride, SPA_POD_CHOICE_RANGE_Int(stride, stride, INT32_MAX),
SPA_PARAM_BUFFERS_align, SPA_POD_Int(16),
Expand Down

0 comments on commit 2d031d6

Please sign in to comment.