Replace travis job with github action. #66
Conversation
| find . -type f -name '*.go' | xargs goimports -w | ||
|
|
||
| test: | ||
| go test ./... | ||
|
|
||
| travis: |
There was a problem hiding this comment.
Is it possible to change this to action instead of travis and then call this from the github action.
That way it is possible to reproduce the github action locally before pushing?
There was a problem hiding this comment.
That's a really good idea, I forgot about the possibility to run locally...
In order to have separated steps in github action, I will add different rules to Makefile (dependencies, build and checkers) and an action one that calls the others.
Github actions also run on pull_request. Add help option to Makefile.
It is configured to run |
| help: | ||
| @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' | ||
|
|
||
| regenerate: ## Re-generate lexers and parsers and pass through goimports |
There was a problem hiding this comment.
This looks great 👍
I do not see the regenerate step in github actions.
The git diff --exit-code is also used to check that the newest generated code was checked in.
Otherwise it looks amazing :D
There was a problem hiding this comment.
Sorry, missed regenerate.
One question, when I execute make regenerate, the created imports for errors and token are local paths. I was expecting import with github.com/jmrtt/gographviz or better yet with github.com/awalterschulze/gographviz. So I'm missing something here.
The import after running make regenerate looks like "home/roquette/gographviz/internal/token" and goimport gives an error as expected. What I'm doing wrong?
There was a problem hiding this comment.
I saw that is possible to specify the package in gocc command-line using -p. But it was being ignored since the output is going to ./internal due to https://github.com/goccmack/gocc/blob/65cbc60dd30507e085bed479695e11aaf6fe9c2e/internal/config/config.go#L184
So, I changed the makefile to pass the package as parameter and generate inside internal folder (cd internal; gocc -zip -p github.com/awalterschulze/gographviz/internal ../dot.bnf). Please check if this is the best way to perform this in my last commit.
With this, I updated the generated code and is possible to check using git diff --exit-code.
Last run of the action can be found in: https://github.com/jmrtt/gographviz/runs/1205227899
There was a problem hiding this comment.
Aha I think the problem is the GOPATH variable needs to be set.
I think gocc uses the GOPATH to generate the paths.
I think travis used to set this as part of its default go setup
There was a problem hiding this comment.
I think with setting the GOPATH we should be able to get away with the old gocc -zip -o ./internal/ dot.bnf which should then also remove the generated txt files, I hope at least.
There was a problem hiding this comment.
Yes it seems it uses the go/build package to figure out the default package
https://github.com/goccmack/gocc/blob/master/internal/config/config.go#L205
I think I still remember encouraging this idea.
There was a problem hiding this comment.
Thank you for putting in this much effort.
I think this work is needed and I do appreciate it.
There was a problem hiding this comment.
Thanks for the all the information! 😄 I will revert my last commit and try setting GOPATH to have gocc -zip -o ./internal/ dot.bnf back. I'll let you know when have a new iteration.
There was a problem hiding this comment.
With GOPATH and correct location, only token.go was updated by regenerate. Generated txt files didn't appear.
So, we already have the regeneration step and github actions working correctly (needed to set GOPATH and working directory to have it working).
Last run of github actions with regenerate: https://github.com/jmrtt/gographviz/runs/1205882765
There was a problem hiding this comment.
Amazing work.
Well done, this looks great.
I think with time of not having a working CI, the token.go got outdated some how. So including in the pull request makes sense :)
Apparently, from what I found, Github action will only run when the workflow is accepted in the repository to prevent abuse in PR. So, when this change is accepted, the next PR will have actions running. The last run on my fork: https://github.com/jmrtt/gographviz/runs/1205050026 |
|
Great job it is working :D <3 Thank you so much.
If you are interested, you are welcome to do it, otherwise I will probably copy your template in a few months. |
|
Glad that I could help! 😄 And thanks for being so helpful! I will take a look at your other projects and issues. |
|
No pressure. Either way, I am already very thankful. |
|
Hii, Thanks, both, for all your work! ❤️ |
Created github action that performs the same tasks as travis job.
Note that the badge in
Readme.mdis already pointing to https://github.com/awalterschulze/gographviz to work correctly when merged.