Check .Message for null #387#389
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Addresses #387 by hardening streaming chat response handling so that response chunks with a null Message are ignored, preventing null dereferences while preserving the final assembled assistant message in chat history.
Changes:
- Update
Chat.SendAsAsync(...)to skip streamed chunks whereanswerisnulloranswer.Messageisnull, and to use a non-nullanswerMessageChunkforThinking/Contentaccess. - Add a unit test ensuring streaming ignores response chunks that do not contain a message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/ChatTests.cs | Adds coverage to ensure streamed chunks with Message = null are ignored and do not break streaming/output. |
| src/OllamaSharp/Chat.cs | Prevents null dereferences by skipping chunks without a Message and reading Thinking/Content via a non-null pattern match. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 15, 2026
Merged
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.