Remove newassets from iframe selector #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the subdomain
newassets
from the iframe selectors. The reason for the change is because the Cloudflare pages that I've seen on https://boxrec.com and https://www.escapefromtarkov.com/registration, both had iframes withoutnewassets
. When the package tries to get the iframe, it'll fail. This makes the selector for iframe less strict and prone to breakage.I believe BoxRec didn't have a subdomain (didn't take screenshot), where the Tarkov website was instead under
cf-assets
as can be seen below.newassets
subdomainEverything else seems to be the same, like the version from JWT, it's still
newassets
. The only thing that could potentially need updating is theOrigin
for thechecksiteconfig
endpoint. I did see it withcf-assets
. I've left it as is for now, it worked unchanged.cf-assets
in theOrigin
, where this package I've left asnewassets
Also while I'm here, do you know if there's a surefire way to re-trigger the Cloudflare captcha pages on websites? I've passed the Cloudflare check on a certain website and I'd like to be able to go back to it.
Thanks