This repository has been archived by the owner on May 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetexe
reviewed
Jul 24, 2019
Reallife
suggested changes
Jul 24, 2019
DenSul
reviewed
Jul 24, 2019
bin/rr-worker
Outdated
global $argv; | ||
global $argv, $_ENV; | ||
|
||
$worker_class = isset($_ENV['RR_WORKER_CLASS']) && \is_string($_ENV['RR_WORKER_CLASS']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using global variables is a bad idea, maybe getenv / filter_input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI context =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
jetexe
approved these changes
Jul 24, 2019
Reallife
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
SetServerPortMiddleware
for automatic settingSERVER_PORT
in server parameters bag if it does not set before (value based on request schema; this middleware fixes empty port value likehttps://127.0.0.1:/
when exposed default port without setSERVER_PORT
)RR_WORKER_CLASS
supports for overriding default worker class (watch in./bin/rr-worker
)Makefile
Changed
http.fcgi.*
,http.http2.*
,headers.*
) (do not forget update your existing config files)Laravel
version now is5.5.x
spiral/roadrunner
version now is^1.4.6
SetServerPortMiddleware
middlewareRULE_METHOD_PREFIX
inCallbacksInitializer
class now protectedBOOL_OPTION_INVERT_LOGIC_NAME_PREFIX
andOPTIONS_PREFIX
inStartOptions
class now protectedstart()
must returnsvoid
inWorkerInterface
interfaceRemoved
avto-dev/dev-tools
Checklist