Skip to content
This repository has been archived by the owner on May 25, 2020. It is now read-only.

Improve v2 #17

Merged
merged 9 commits into from
Jul 24, 2019
Merged

Improve v2 #17

merged 9 commits into from
Jul 24, 2019

Conversation

tarampampam
Copy link
Contributor

Q A
Bug fix? Yes
New feature? Yes

Description

Added

  • Middleware SetServerPortMiddleware for automatic setting SERVER_PORT in server parameters bag if it does not set before (value based on request schema; this middleware fixes empty port value like https://127.0.0.1:/ when exposed default port without set SERVER_PORT)
  • Environment variable RR_WORKER_CLASS supports for overriding default worker class (watch in ./bin/rr-worker)
  • Docker-based environment for development
  • Project Makefile

Changed

  • Allowed RR configuration options (http.fcgi.*, http.http2.*, headers.*) (do not forget update your existing config files)
  • Minimal Laravel version now is 5.5.x
  • Minimal spiral/roadrunner version now is ^1.4.6
  • Composer scripts
  • Package service-provider automatically register SetServerPortMiddleware middleware
  • Constant RULE_METHOD_PREFIX in CallbacksInitializer class now protected
  • Constants BOOL_OPTION_INVERT_LOGIC_NAME_PREFIX and OPTIONS_PREFIX in StartOptions class now protected
  • Method start() must returns void in WorkerInterface interface

Removed

  • Dev-dependency avto-dev/dev-tools

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code
  • I have made changes in CHANGELOG.md file

About your changes in CHANGELOG.md:

  • Add new version header like ## v1.x.x, if it does not exists
  • Add description under Added / Changed / Fixed sections
  • Add reference to closed issues [#000]
  • Add link to issue in the end of document

@tarampampam tarampampam added the type:enhancement New feature or request label Jul 23, 2019
@tarampampam tarampampam self-assigned this Jul 23, 2019
configs/rr/.rr.local.yml Outdated Show resolved Hide resolved
bin/rr-worker Outdated
global $argv;
global $argv, $_ENV;

$worker_class = isset($_ENV['RR_WORKER_CLASS']) && \is_string($_ENV['RR_WORKER_CLASS'])
Copy link
Contributor

@DenSul DenSul Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using global variables is a bad idea, maybe getenv / filter_input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI context =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@tarampampam tarampampam merged commit d362f05 into master Jul 24, 2019
@tarampampam tarampampam deleted the improve-v2 branch July 24, 2019 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants