Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Importer refactoring #436

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pixelhed
Copy link
Contributor

integrate refactoring done by @sprankhub in #393

@pixelhed
Copy link
Contributor Author

@sprankhub can you check to see if this integrates what you did correctly please?

@sprankhub
Copy link
Collaborator

Thanks @pixelhed! Most of the stuff looks good. Anyway, are you sure that this works correctly? I am missing the part, where link_type = file is used:

https://github.com/avstudnitz/AvS_FastSimpleImport/pull/393/files#diff-f8e8d5f37e9620023fd30064b683d27bR2065

I did not test though, I just did a code review.

@pixelhed
Copy link
Contributor Author

I am missing the part, where link_type = file is used:

if you look here:

you will see that it is set depending upon the type of link being imported.

@sprankhub
Copy link
Collaborator

Okay awesome. As said, I could not test it, but you tested it, right? Did you also verify that imported downloadable files are structured in the way Magento does it usually (in subfolder à la /t/e/test.zip). If yes, I am happy to merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants