Avoid the CI from crashing#46
Closed
kit-ty-kate wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
This is still unresolved and I'm not sure what to do about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conduit 2.0.0 / Cohttp 2.2.0 fix an issue that makes a cohttp server crash if no exception handler has been defined.
However mirage-ci uses datakit-ci, which is not compatible with this version of conduit yet.
As a temporary fix, we define the Lwt exception handler in mirage-ci. This should take care of the issue.
I'm not entirely sure why we didn't get more of that failure sooner but at least this way it is fixed anyway.
More details in mirage/ocaml-conduit#261 and mirage/ocaml-cohttp#669