Support gradient #1
Conversation
| getLinkColor(): string[] | string | undefined| null { | ||
| const { linkData, pathColorFunc } = this.props; | ||
| let color = pathColorFunc; | ||
| if (typeof pathColorFunc === 'function') { |
There was a problem hiding this comment.
Let's remove the support for non-function here - just always call pathColorFunc (also the Props typing says its always a function)
There was a problem hiding this comment.
We still need to check if pathColorFunc is a function
There was a problem hiding this comment.
Why? In TypeScript we shouldn't verify, we depend on the using code to have TypeScript as well, or to be responsible. See other function props above - they don't verify them.
src/Link/index.tsx
Outdated
| data-target-id={linkData.target.id} | ||
| /> | ||
| <> | ||
| {gradientStartColor && <defs> |
There was a problem hiding this comment.
Consider extracting this to a method to be used like this {this.getGradientDef(gradientStartColor, gradientEndColor) (linkData can be extracted from the props inside getGradientDef)
src/Link/index.tsx
Outdated
| /> | ||
| <> | ||
| {gradientStartColor && <defs> | ||
| <linearGradient x1={linkData.source.x} y1={linkData.source.y} x2={linkData.target.x} y2={linkData.target.y} id={gradientId} gradientUnits="userStepOnUse"> |
There was a problem hiding this comment.
That's an invalid value for gradientUnits, you mean userSpaceOnUse:
| <linearGradient x1={linkData.source.x} y1={linkData.source.y} x2={linkData.target.x} y2={linkData.target.y} id={gradientId} gradientUnits="userStepOnUse"> | |
| <linearGradient x1={linkData.source.x} y1={linkData.source.y} x2={linkData.target.x} y2={linkData.target.y} id={gradientId} gradientUnits="userSpaceOnUse"> |
No description provided.