Remove ac_cfg.h from libavrdude.h

[dl8dtl]

Inclusion of ac_cfg.h is not needed, and contradicts the library idea.

[yegorich]

I have used the following code:

#include <stdio.h>
#include "libavrdude.h"

int main(int argc, char **argv)
{
        AVRMEM *mem = avr_new_memtype();
        printf("Hello world\n");
        return 0;
}

root@onrisc:/usr/src/avrtest# gcc -o test main.c libavrdude.a
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_new_opcode':
/usr/src/avrdude/src/avrpart.c:39: undefined reference to `avrdude_message'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_new_memtype':
/usr/src/avrdude/src/avrpart.c:252: undefined reference to `avrdude_message'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_initmem':
/usr/src/avrdude/src/avrpart.c:276: undefined reference to `avrdude_message'
/usr/bin/ld: /usr/src/avrdude/src/avrpart.c:282: undefined reference to `avrdude_message'
/usr/bin/ld: /usr/src/avrdude/src/avrpart.c:284: undefined reference to `progname'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_dup_opcode':
/usr/src/avrdude/src/avrpart.c:59: undefined reference to `avrdude_message'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_dup_mem':
/usr/src/avrdude/src/avrpart.c:314: undefined reference to `avrdude_message'
/usr/bin/ld: /usr/src/avrdude/src/avrpart.c:304: undefined reference to `avrdude_message'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_new_memtype':
/usr/src/avrdude/src/avrpart.c:252: undefined reference to `avrdude_message'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o): in function `avr_mem_display':
/usr/src/avrdude/src/avrpart.c:408: undefined reference to `avrdude_message'
/usr/bin/ld: libavrdude.a(libavrdude_a-avrpart.o):/usr/src/avrdude/src/avrpart.c:445: more undefined references to `avrdude_message' follow
/usr/bin/ld: libavrdude.a(libavrdude_a-pindefs.o): in function `pins_check':
/usr/src/avrdude/src/pindefs.c:296: undefined reference to `progname'
collect2: error: ld returned 1 exit status

[dl8dtl]

avrdude_message() needs to be provided by the application.
The template in main.c can be used, but it depends on the verbose global variable which is only available in main.c.

Yes, we should document that. ;-)

Btw., it's on purpose that this needs to be provided by the application: if you want to build a GUI app (which was the original idea behind splitting off the backend functionality into a library), you certainly don't want to see those messages go to a console terminal, but somehow create a GUI message box out of that.

[yegorich]

With avrdude_message() provided everything works fine.