Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yml to add MSYS2 ucrt64, clang32 and clang64 build #1612

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Jan 8, 2024

This PR adds github action build for MSYS2 ucrt64, clang32 and clang64 for Windows.
clangarm64 is not added as it is still not as mature.

Reference:
https://www.msys2.org/docs/environments/

@mcuee mcuee added the enhancement New feature or request label Jan 8, 2024
@mcuee
Copy link
Collaborator Author

mcuee commented Jan 8, 2024

clang compilers sometimes capture more codes issues compared to gcc and MSVC.

For example, the following warnings are generated by clang64 build against git main.
https://github.com/avrdudes/avrdude/actions/runs/7442516451/job/20246066588

[ 61%] Building C object src/CMakeFiles/libavrdude.dir/ser_win32.c.obj
D:/a/avrdude/avrdude/src/ser_win32.c:440:3: warning: comparison of integers of different signs: 'SOCKET' (aka 'unsigned long long') and 'const int' [-Wsign-compare]
  440 |                 FD_SET(fd->ifd, &rfds);
      |                 ^~~~~~~~~~~~~~~~~~~~~~
D:/a/_temp/msys64/clang64/include/psdk_inc/_fd_types.h:77:40: note: expanded from macro 'FD_SET'
   77 |                 if (((fd_set *)(set))->fd_array[__i] == (fd)) {         \
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^   ~~
D:/a/avrdude/avrdude/src/ser_win32.c:[56](https://github.com/avrdudes/avrdude/actions/runs/7442516451/job/20246066588#step:5:57)1:3: warning: comparison of integers of different signs: 'SOCKET' (aka 'unsigned long long') and 'const int' [-Wsign-compare]
  5[61](https://github.com/avrdudes/avrdude/actions/runs/7442516451/job/20246066588#step:5:62) |                 FD_SET(fd->ifd, &rfds);
      |                 ^~~~~~~~~~~~~~~~~~~~~~
D:/a/_temp/msys[64](https://github.com/avrdudes/avrdude/actions/runs/7442516451/job/20246066588#step:5:65)/clang64/include/psdk_inc/_fd_types.h:77:40: note: expanded from macro 'FD_SET'
   77 |                 if (((fd_set *)(set))->fd_array[__i] == (fd)) {         \
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^   ~~
2 warnings generated.

@stefanrueger stefanrueger merged commit a8837f4 into avrdudes:main Jan 8, 2024
13 checks passed
@stefanrueger
Copy link
Collaborator

@mcuee I don't think these two warnings are significant, and I suggest not fixing these as that's not critical for v7.3

@mcuee
Copy link
Collaborator Author

mcuee commented Jan 8, 2024

@mcuee I don't think these two warnings are significant, and I suggest not fixing these as that's not critical for v7.3

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants