Ensure full words are loaded, low-byte first, for ISP programming #1265

stefanrueger · 2023-01-04T16:55:53Z

Addresses Issue #1263

Although the ISP interface for classic parts loads pages byte for byte (not word for word) into a buffer on chip, the data sheets say that the low byte must be written before the high byte for programming to work. This PR ensures that. The problem with the current code is that perfectly legal hex files can just set high bytes from time to time (odd start address of blocks etc).

cinderblock · 2023-01-04T21:33:47Z

Seems to work with ATMega32U4-usbdevice_dfu-1_0_0.hex

mcuee · 2023-01-04T23:30:21Z

Seems to work with ATMega32U4-usbdevice_dfu-1_0_0.hex

I can reproduce Issue #1263 and I can confirm this PR #1265 fixed the issue reported in #1263.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude -c linuxspi -p m32u4
 -U ./ATMega32U4-usbdevice_dfu-1_0_0.hex 

avrdude: AVR device initialized and ready to accept instructions
avrdude: device signature = 0x1e9587 (probably m32u4)
avrdude: Note: flash memory has been specified, an erase cycle will be performed.
         To disable this feature, specify the -D option.
avrdude: erasing chip
avrdude: reading input file ./ATMega32U4-usbdevice_dfu-1_0_0.hex for flash
         with 3948 bytes in 5 sections within [0x7000, 0x7fff]
         using 32 pages and 148 pad bytes
avrdude: writing 3948 bytes flash ...

Writing | ################################################## | 100% 1.06 s 

avrdude: 3948 bytes of flash written
avrdude: verifying flash memory against ./ATMega32U4-usbdevice_dfu-1_0_0.hex

Reading | ################################################## | 100% 0.92 s 

avrdude warning: verification mismatch
        device 0xff != input 0x7f at addr 0x7090 (error)
avrdude error: verification mismatch

avrdude done.  Thank you.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude_pr1265 -c linuxspi -p m32u4 
-U ./ATMega32U4-usbdevice_dfu-1_0_0.hex 

avrdude_pr1265: AVR device initialized and ready to accept instructions
avrdude_pr1265: device signature = 0x1e9587 (probably m32u4)
avrdude_pr1265: Note: flash memory has been specified, an erase cycle will be performed.
                To disable this feature, specify the -D option.
avrdude_pr1265: erasing chip
avrdude_pr1265: reading input file ./ATMega32U4-usbdevice_dfu-1_0_0.hex for flash
                with 3948 bytes in 5 sections within [0x7000, 0x7fff]
                using 32 pages and 148 pad bytes
avrdude_pr1265: writing 3948 bytes flash ...

Writing | ################################################## | 100% 1.05 s 

avrdude_pr1265: 3948 bytes of flash written
avrdude_pr1265: verifying flash memory against ./ATMega32U4-usbdevice_dfu-1_0_0.hex

Reading | ################################################## | 100% 0.92 s 

avrdude_pr1265: 3948 bytes of flash verified

avrdude_pr1265 done.  Thank you.

mcuee

Tested to be good.

mcuee · 2023-01-04T23:36:59Z

Same for linuxgpio. Issue #1263 also affected linuxgpio and this PR fixed the issue.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude_pr1265 -c linuxgpio -p m32u4 -U ./ATMega32U4-usbdevice_dfu-1_0_0.hex 

avrdude_pr1265: AVR device initialized and ready to accept instructions
avrdude_pr1265: device signature = 0x1e9587 (probably m32u4)
avrdude_pr1265: Note: flash memory has been specified, an erase cycle will be performed.
                To disable this feature, specify the -D option.
avrdude_pr1265: erasing chip
avrdude_pr1265: reading input file ./ATMega32U4-usbdevice_dfu-1_0_0.hex for flash
                with 3948 bytes in 5 sections within [0x7000, 0x7fff]
                using 32 pages and 148 pad bytes
avrdude_pr1265: writing 3948 bytes flash ...

Writing | ################################################## | 100% 0.85 s 

avrdude_pr1265: 3948 bytes of flash written
avrdude_pr1265: verifying flash memory against ./ATMega32U4-usbdevice_dfu-1_0_0.hex

Reading | ################################################## | 100% 0.67 s 

avrdude_pr1265: 3948 bytes of flash verified

avrdude_pr1265 done.  Thank you.

mcuee · 2023-01-05T00:04:31Z

I am having some connection issues with the ribbon cables with the ATmega2560 so that I can not test Issue #455 now with the ATmega2560.

Edit: never mind, the hex file is generic and I can reproduce issue #455 using ATmega328P, Again PR #1265 is good to fix the issue.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude -c linuxgpio -p m328p -U ./blink-2560-mod.hex 

avrdude: AVR device initialized and ready to accept instructions
avrdude: device signature = 0x1e950f (probably m328p)
avrdude: Note: flash memory has been specified, an erase cycle will be performed.
         To disable this feature, specify the -D option.
avrdude: erasing chip
avrdude: reading input file ./blink-2560-mod.hex for flash
         with 1489 bytes in 2 sections within [0, 0x5d1]
         using 12 pages and 47 pad bytes
avrdude: writing 1489 bytes flash ...

Writing | ################################################## | 100% 0.33 s 

avrdude: 1489 bytes of flash written
avrdude: verifying flash memory against ./blink-2560-mod.hex

Reading | ################################################## | 100% 0.26 s 

avrdude warning: verification mismatch
        device 0xff != input 0x00 at addr 0x05ce (error)
avrdude error: verification mismatch

avrdude done.  Thank you.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude_pr1265 -c linuxgpio -p m328p -U ./blink-2560-mod.hex 

avrdude_pr1265: AVR device initialized and ready to accept instructions
avrdude_pr1265: device signature = 0x1e950f (probably m328p)
avrdude_pr1265: Note: flash memory has been specified, an erase cycle will be performed.
                To disable this feature, specify the -D option.
avrdude_pr1265: erasing chip
avrdude_pr1265: reading input file ./blink-2560-mod.hex for flash
                with 1489 bytes in 2 sections within [0, 0x5d1]
                using 12 pages and 47 pad bytes
avrdude_pr1265: writing 1489 bytes flash ...

Writing | ################################################## | 100% 0.36 s 

avrdude_pr1265: 1489 bytes of flash written
avrdude_pr1265: verifying flash memory against ./blink-2560-mod.hex

Reading | ################################################## | 100% 0.27 s 

avrdude_pr1265: 1489 bytes of flash verified

avrdude_pr1265 done.  Thank you.

mcuee · 2023-01-05T00:15:06Z

Issue #1263 can be reproduced with ATmega328P as well, for linuxgpio. Again this PR fixed the issue.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude -c linuxgpio -p m328p -U ./ATMega32U4-usbdevice_dfu-1_0_0.hex 

avrdude: AVR device initialized and ready to accept instructions
avrdude: device signature = 0x1e950f (probably m328p)
avrdude: Note: flash memory has been specified, an erase cycle will be performed.
         To disable this feature, specify the -D option.
avrdude: erasing chip
avrdude: reading input file ./ATMega32U4-usbdevice_dfu-1_0_0.hex for flash
         with 3948 bytes in 5 sections within [0x7000, 0x7fff]
         using 32 pages and 148 pad bytes
avrdude: writing 3948 bytes flash ...

Writing | ################################################## | 100% 0.85 s 

avrdude: 3948 bytes of flash written
avrdude: verifying flash memory against ./ATMega32U4-usbdevice_dfu-1_0_0.hex

Reading | ################################################## | 100% 0.67 s 

avrdude warning: verification mismatch
        device 0xff != input 0x7f at addr 0x7090 (error)
avrdude error: verification mismatch

avrdude done.  Thank you.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude_pr1265 -c linuxgpio -p m328p -U ./ATMega32U4-usbdevice_dfu-1_0_0.hex 

avrdude_pr1265: AVR device initialized and ready to accept instructions
avrdude_pr1265: device signature = 0x1e950f (probably m328p)
avrdude_pr1265: Note: flash memory has been specified, an erase cycle will be performed.
                To disable this feature, specify the -D option.
avrdude_pr1265: erasing chip
avrdude_pr1265: reading input file ./ATMega32U4-usbdevice_dfu-1_0_0.hex for flash
                with 3948 bytes in 5 sections within [0x7000, 0x7fff]
                using 32 pages and 148 pad bytes
avrdude_pr1265: writing 3948 bytes flash ...

Writing | ################################################## | 100% 0.85 s 

avrdude_pr1265: 3948 bytes of flash written
avrdude_pr1265: verifying flash memory against ./ATMega32U4-usbdevice_dfu-1_0_0.hex

Reading | ################################################## | 100% 0.68 s 

avrdude_pr1265: 3948 bytes of flash verified

avrdude_pr1265 done.  Thank you.

mcuee · 2023-01-05T00:16:26Z

@stefanrueger
This PR is good to go from my side.

For sanity check, I also tested with usbasp and there is no issue with git main or this PR.

stefanrueger · 2023-01-05T08:57:54Z

Great to know this solved the issue. Thanks for feedback @cinderblock and @mcuee.

I reviewed the current PR again and identified two subtle problems:

Loading flash low-byte first is only need when the flash memory is actually paged
Marking extra bytes as TAG_ALLOCATED can lead to false verification errors, eg, when programming odd bytes of flash first, then even bytes, as in -e -U odd.hex -U even.hex; this will program correctly but throw false verification errors on -U even.hex as the additional padding 0xff bytes (that write as NOP) would be checked against previously loaded odd bytes.

So I changed tack and made do without marking extra bytes TAG_ALLOCATED. The new PR also streamlines the programming code (though some might think steamrolls the programming code 😉)

I believe this PR to be production ready, but would be cool if it could be tested.

mcuee · 2023-01-05T12:49:35Z

@stefanrueger

It seems to be fine.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude_pr1265v1 -c linuxgpio -p m328p
 -U ./ATMega32U4-usbdevice_dfu-1_0_0.hex 

avrdude_pr1265v1: AVR device initialized and ready to accept instructions
avrdude_pr1265v1: device signature = 0x1e950f (probably m328p)
avrdude_pr1265v1: Note: flash memory has been specified, an erase cycle will be performed.
                  To disable this feature, specify the -D option.
avrdude_pr1265v1: erasing chip
avrdude_pr1265v1: reading input file ./ATMega32U4-usbdevice_dfu-1_0_0.hex for flash
                  with 3948 bytes in 5 sections within [0x7000, 0x7fff]
                  using 32 pages and 148 pad bytes
avrdude_pr1265v1: writing 3948 bytes flash ...

Writing | ################################################## | 100% 0.87 s 

avrdude_pr1265v1: 3948 bytes of flash written
avrdude_pr1265v1: verifying flash memory against ./ATMega32U4-usbdevice_dfu-1_0_0.hex

Reading | ################################################## | 100% 0.67 s 

avrdude_pr1265v1: 3948 bytes of flash verified

avrdude_pr1265v1 done.  Thank you.

pi@raspberrypi:~/build/avr/avrdude_bin $ ./avrdude_pr1265v1 -c linuxgpio -p m328p
 -U ./blink-2560-mod.hex 

avrdude_pr1265v1: AVR device initialized and ready to accept instructions
avrdude_pr1265v1: device signature = 0x1e950f (probably m328p)
avrdude_pr1265v1: Note: flash memory has been specified, an erase cycle will be performed.
                  To disable this feature, specify the -D option.
avrdude_pr1265v1: erasing chip
avrdude_pr1265v1: reading input file ./blink-2560-mod.hex for flash
                  with 1489 bytes in 2 sections within [0, 0x5d1]
                  using 12 pages and 47 pad bytes
avrdude_pr1265v1: writing 1489 bytes flash ...

Writing | ################################################## | 100% 0.34 s 

avrdude_pr1265v1: 1489 bytes of flash written
avrdude_pr1265v1: verifying flash memory against ./blink-2560-mod.hex

Reading | ################################################## | 100% 0.27 s 

avrdude_pr1265v1: 1489 bytes of flash verified

avrdude_pr1265v1 done.  Thank you.

stefanrueger added 2 commits January 4, 2023 16:44

Simplify ISP write logic in avr_write_mem()

5855e22

Ensure both bytes of a needed word in flash are TAG_ALLOCATED

695e8a5

stefanrueger linked an issue Jan 4, 2023 that may be closed by this pull request

linuxgpio and linuxspi issue: Official .hex from Atmel doesn't program correctly #1263

Closed

stefanrueger added the bug Something isn't working label Jan 4, 2023

stefanrueger requested a review from dl8dtl January 4, 2023 16:56

stefanrueger mentioned this pull request Jan 4, 2023

Add readline library replacement for MSVC #1264

Merged

stefanrueger linked an issue Jan 4, 2023 that may be closed by this pull request

[bug #51320] linuxgpio and linuxspi problem: 0x00 written as 0xFF when byte count is less than 0x10 in hex file lines #455

Closed

stefanrueger mentioned this pull request Jan 4, 2023

linuxgpio and linuxspi issue: Official .hex from Atmel doesn't program correctly #1263

Closed

mcuee approved these changes Jan 4, 2023

View reviewed changes

This was referenced Jan 5, 2023

[bug #51320] linuxgpio and linuxspi problem: 0x00 written as 0xFF when byte count is less than 0x10 in hex file lines #455

Closed

linuxgpio issues #932

Closed

Ensure words are loaded, low-byte first, for ISP programming

00a9354

stefanrueger changed the title ~~Ensure both bytes of a needed word in flash are TAG_ALLOCATED~~ Ensure full words are loaded, low-byte first, for ISP programming Jan 5, 2023

stefanrueger merged commit 653d66b into avrdudes:main Jan 5, 2023

stefanrueger deleted the avr-isp-write branch January 5, 2023 16:43

mcuee mentioned this pull request Jan 6, 2023

[bug #48261] STK500V2 ISP problem with ATmega8/8515/8535, ATmega16 and ATmega32 #425

Closed

stefanrueger mentioned this pull request Jan 8, 2023

FLASH write fails if there are odd number of bytes. #1068

Closed

mcuee mentioned this pull request Jun 3, 2023

Remove pgm->page_erase() function when unable to erase page #1376

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure full words are loaded, low-byte first, for ISP programming #1265

Ensure full words are loaded, low-byte first, for ISP programming #1265

stefanrueger commented Jan 4, 2023

cinderblock commented Jan 4, 2023

mcuee commented Jan 4, 2023

mcuee left a comment

mcuee commented Jan 4, 2023

mcuee commented Jan 5, 2023 •

edited

Loading

mcuee commented Jan 5, 2023

mcuee commented Jan 5, 2023 •

edited

Loading

stefanrueger commented Jan 5, 2023 •

edited

Loading

mcuee commented Jan 5, 2023 •

edited

Loading

Ensure full words are loaded, low-byte first, for ISP programming #1265

Ensure full words are loaded, low-byte first, for ISP programming #1265

Conversation

stefanrueger commented Jan 4, 2023

cinderblock commented Jan 4, 2023

mcuee commented Jan 4, 2023

mcuee left a comment

Choose a reason for hiding this comment

mcuee commented Jan 4, 2023

mcuee commented Jan 5, 2023 • edited Loading

mcuee commented Jan 5, 2023

mcuee commented Jan 5, 2023 • edited Loading

stefanrueger commented Jan 5, 2023 • edited Loading

mcuee commented Jan 5, 2023 • edited Loading

mcuee commented Jan 5, 2023 •

edited

Loading

mcuee commented Jan 5, 2023 •

edited

Loading

stefanrueger commented Jan 5, 2023 •

edited

Loading

mcuee commented Jan 5, 2023 •

edited

Loading