Test coverage with multiprocessing fix #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtja
force-pushed
the
coverage_multiprocessing_fix
branch
from
091f459 to
ed6e56e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
===========================================
+ Coverage 54.47% 68.67% +14.20%
===========================================
Files 202 202
Lines 21892 21892
===========================================
+ Hits 11925 15034 +3109
+ Misses 9967 6858 -3109 ☔ View full report in Codecov by Sentry. |
richtja
force-pushed
the
coverage_multiprocessing_fix
branch
from
ed6e56e to
d60eb45
Compare
The test coverage of avocado gathered by coverage.py. It was not precise, because some of our functional tests were running in sub-processes where the coverage was not enabled. This change it adds `sitecustomize.py` to ensure that coverage will be enabled for all python processes which will run during coverage testing. After this change, the overall test coverage of avocado will increase from 54% to 68% Reference: https://coverage.readthedocs.io/en/latest/subprocess.html Signed-off-by: Jan Richter <[email protected]>
richtja
force-pushed
the
coverage_multiprocessing_fix
branch
from
d60eb45 to
cee5223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test coverage of avocado gathered by coverage.py. It was not precise, because some of our functional tests were running in sub-processes where the coverage was not enabled. This change it adds
sitecustomize.pyto ensure that coverage will be enabled for all python processes which will run during coverage testing. After this change, the overall test coverage of avocado will increase from 54% to 68%Reference: https://coverage.readthedocs.io/en/latest/subprocess.html
As an example of not working, coverage testing can be #6072. Where the coverage of new runner is 0 even tho the PR introduce its testing.