🚨 refactor: better engine mounting

config/routes.rb

@@ -4,11 +4,6 @@
   get "resources", to: redirect(Avo.configuration.root_path)
   get "dashboards", to: redirect(Avo.configuration.root_path)
 
-  # Mount Avo engines routes by default but leave it configurable in case the user wants to nest these under a scope.
-  if Avo.configuration.mount_avo_engines
-    instance_exec(&Avo.mount_engines)
-  end
-
   post "/rails/active_storage/direct_uploads", to: "/active_storage/direct_uploads#create"
 
   scope "avo_api", as: "avo_api" do

lib/avo.rb

@@ -130,16 +130,6 @@ def has_profile_menu?
       true
     end
 
-    # Mount all Avo engines
-    def mount_engines
-      -> {
-        mount Avo::DynamicFilters::Engine, at: "/avo-dynamic_filters" if defined?(Avo::DynamicFilters::Engine)
-        mount Avo::Dashboards::Engine, at: "/dashboards" if defined?(Avo::Dashboards::Engine)
-        mount Avo::Pro::Engine, at: "/avo-pro" if defined?(Avo::Pro::Engine)
-        mount Avo::Kanban::Engine, at: "/boards" if defined?(Avo::Kanban::Engine)
-      }
-    end
-
     def extra_gems
       [:pro, :advanced, :menu, :dynamic_filters, :dashboards, :enterprise, :audits]
     end

lib/avo/engine.rb

@@ -42,7 +42,8 @@ class Engine < ::Rails::Engine
     # Ensure we reboot the app when something changes
     config.to_prepare do
       # Boot Avo
-      ::Avo.boot
+      # TODO: I think we can remove this
+      # ::Avo.boot
     end
 
     initializer "avo.autoload" do |app|
@@ -59,6 +60,17 @@ class Engine < ::Rails::Engine
           app.config.watchable_dirs[directory_path] = [:rb]
         end
       end
+
+      # Add the mount_avo method to Rails
+      ActionDispatch::Routing::Mapper.include(Module.new {
+        def mount_avo(at: Avo.configuration.root_path, **options)
+          mount Avo::Engine, at:, **options
+
+          Avo.plugin_manager.engines.each do |engine|
+            mount engine[:klass], **engine[:options]
+          end
+        end
+      })
     end
 
     initializer "avo.reloader" do |app|

lib/avo/plugin_manager.rb

@@ -1,11 +1,13 @@
 module Avo
   class PluginManager
     attr_reader :plugins
+    attr_accessor :engines
 
     alias_method :all, :plugins
 
     def initialize
       @plugins = []
+      @engines = []
     end
 
     def register(name, priority: 10)
@@ -50,6 +52,10 @@ def installed?(name)
         plugin.name.to_s == name.to_s
       end
     end
+
+    def mount_engine(klass, **options)
+      @engines << {klass:, options:}
+    end
   end
 
   def self.plugin_manager

spec/dummy/config/routes.rb

@@ -12,17 +12,18 @@
       get "custom_tool", to: "avo/tools#custom_tool", as: :custom_tool
     end
 
-    mount Avo::Engine, at: Avo.configuration.root_path
+    mount_avo
+
     # Uncomment to test constraints /123/en/admin
     # scope ":course", constraints: {course: /\w+(-\w+)*/} do
     #   scope ":locale", constraints: {locale: /\w[-\w]*/} do
-    #     mount Avo::Engine, at: Avo.configuration.root_path
+    #     mount_avo
     #   end
     # end
 
     # TODO: support locale based routes
     scope "(:locale)" do
-      # mount Avo::Engine, at: Avo.configuration.root_path
+      # mount_avo
     end
   end
 end