Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: grid item badge #3478

Merged
merged 6 commits into from
Dec 3, 2024
Merged

feature: grid item badge #3478

merged 6 commits into from
Dec 3, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Dec 2, 2024

Description

Adds the ability to add badges on grid items 🙌

Docs

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

CleanShot 2024-12-02 at 14 53 44@2x

Manual review steps

  1. Set grid_view card with badge_label. Optionally badge_color
  2. See that resource and observe the badge.

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Dec 2, 2024

Code Climate has analyzed commit e564dd3 and detected 0 issues on this pull request.

View more on Code Climate.

spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/product.rb Outdated Show resolved Hide resolved
@adrianthedev
Copy link
Collaborator Author

Someone was requesting this feature in the past. Was it you, @iainbeeston?

@iainbeeston
Copy link
Contributor

Yes it was! That would be very helpful 🙌

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Paul-Bob Paul-Bob merged commit 590c9e9 into main Dec 3, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the feature/grid-item-badge branch December 3, 2024 07:47
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@iainbeeston
Copy link
Contributor

iainbeeston commented Dec 4, 2024

This looks great btw - it's allowed me to remove a lot of custom formatting and grid item descriptions and use badges instead 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants