fix: broken attach and attach another button for searchable associations

[ObiWanKeoni]

Description

I think this is all that's necessary to fix the issue linked below. In the AssociationsController, we expect a :turbo_frame param to be passed to the route if we want to rerender the turbo frame instead of closing it. The only bit I'm unclear on is whether we need to have additional special handling for the attach_another button. I figured this was enough.

Fixes #3456

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit 3221d4c and detected 0 issues on this pull request.

View more on Code Climate.

[Paul-Bob]

Hi @ObiWanKeoni thank you for looking into this and opening this PR!

What happens is that this hidden form field was introduced only for non-searchable fields.

To complete this PR let's remove that hidden field and keep the turbo frame on the url params, or remove it from the params and move the hidden form field outside the if searchable condition ensuring that it always render.

[ObiWanKeoni]

@Paul-Bob I added a comment here for communication purposes. LMK if it should be reworded or if this works. Thank you for your comment - I completely missed the hidden_field_tag!

[Paul-Bob]

Awesome! Thank you @ObiWanKeoni!

[Paul-Bob]

Thanks for this contribution @ObiWanKeoni!