Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: summarizable associations #3428

Merged
merged 5 commits into from
Dec 2, 2024
Merged

feature: summarizable associations #3428

merged 5 commits into from
Dec 2, 2024

Conversation

thiagoyoussef
Copy link
Contributor

Description

Fixes #2993

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

CleanShot 2024-11-15 at 13 14 34

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 15, 2024 •
edited
Loading

Code Climate has analyzed commit 07c11f8 and detected 0 issues on this pull request.

View more on Code Climate.

@thiagoyoussef thiagoyoussef force-pushed the feature/summarizable-associations branch from 0036e9c to 26835c0 Compare November 15, 2024 17:11
Paul-Bob
Paul-Bob requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. The scope on association is not applying as expected

image

Let's ensure that we apply the field scope option instead of fetching all associated records using parent.send(association_name).

Paul-Bob
Paul-Bob reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided some code snippets with suggestions (not tested) on how we might apply the scope from the association field

app/controllers/avo/charts_controller.rb Outdated Show resolved Hide resolved
app/controllers/avo/charts_controller.rb Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2024
View reviewed changes
app/controllers/avo/charts_controller.rb Dismissed Show dismissed Hide dismissed
Paul-Bob
Paul-Bob approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the effort on this PR @thiagoyoussef! I've applied some changes to target the parent field scope when present

@Paul-Bob Paul-Bob merged commit 4eb98cd into avo-hq:main Dec 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Bob Paul-Bob Paul-Bob approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make summarizable work under association pages
2 participants
@thiagoyoussef @Paul-Bob