Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add divider to custom list (custom controls) #3407

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Nov 11, 2024

Description

Fixes #3297

Related PR

https://github.com/avo-hq/avo-advanced/pull/51

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

self.index_controls = -> do
  action Avo::Actions::ReleaseFish

  list label: "Custom Index List", icon: "heroicons/outline/cube-transparent", style: :primary, color: :slate, title: "A custom list" do
    link_to "Google", "https://google.com", icon: "heroicons/outline/academic-cap"
    divider label: "↓ Action ↓"
    action Avo::Actions::Sub::DummyAction, icon: "heroicons/outline/globe"
    divider
    link_to "Fish.com", "https://fish.com", icon: "heroicons/outline/fire", target: :_blank
    link_to "Avo", "https://avohq.io/", target: :_blank
  end
end

image

@Paul-Bob Paul-Bob added the Enhancement Not necessarily a feature, but something has improved label Nov 11, 2024
@Paul-Bob Paul-Bob self-assigned this Nov 11, 2024
@Paul-Bob Paul-Bob marked this pull request as draft November 11, 2024 19:04
Copy link

codeclimate bot commented Nov 11, 2024

Code Climate has analyzed commit f51b2c6 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title enhancement: add_divider_to_custom_list enhancement: add divider to custom list (custom controls) Nov 11, 2024
@Paul-Bob Paul-Bob marked this pull request as ready for review November 12, 2024 08:21
@Paul-Bob Paul-Bob merged commit adb68ea into main Nov 18, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the enhancement/add_divider_to_custom_list branch November 18, 2024 08:46
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not necessarily a feature, but something has improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add divider to index_controls > list DSL
1 participant