Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve tippy tooltip to support browser back button #3284

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Sep 30, 2024

Description

Fixes #3265

  • On the first load, get the title attribute value from the element and remove the attribute to prevent the default HTML title behavior.
  • The retrieved title is stored in a new tippy_title attribute to ensure it can be used for future reference.
  • When navigating back via the browser's back button, the tippy_title attribute is used to repopulate the tooltip content instead of relying on the now-removed title attribute.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
tippy_fix.mp4

@Paul-Bob Paul-Bob added the Fix label Sep 30, 2024
Copy link

codeclimate bot commented Sep 30, 2024

Code Climate has analyzed commit 7a69000 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title fix: keep tippy title when browser back is used fix: improve tippy tooltip to support browser back button Sep 30, 2024
@Paul-Bob Paul-Bob self-assigned this Sep 30, 2024
@Paul-Bob Paul-Bob merged commit 9c91b75 into main Sep 30, 2024
22 of 23 checks passed
@Paul-Bob Paul-Bob deleted the fix/keep_tippy_title_when_back branch September 30, 2024 15:49
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

This was referenced Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The description of the “Resource tabs” is not displayed after the browser is backed
1 participant